Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove force full width and use JS to adjust element positions if needed #71

Closed
wants to merge 1 commit into from

Conversation

pookmish
Copy link
Contributor

NOT READY FOR REVIEW

  • (Edit the above to reflect status)

Summary

  • TL;DR - what's this PR for?

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • How critical is this PR on a 1-10 scale? Also see Severity Assessment.
  • E.g., it affects one site, or every site and product?

Urgency

  • How urgent is this? (Normal, High)

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Navigate to...
  4. Verify...

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
summer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 4:55pm

@pookmish
Copy link
Contributor Author

@rebeccahongsf what do you think about this approach? It's not my favorite, but it would allow those pages to have a side navigation as well as full width banners.

useEffect(() => calculateTranslation(), [calculateTranslation])

return (
<div ref={ref} className="relative left-1/2 w-screen -translate-x-1/2">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div ref={ref} className="relative left-1/2 w-screen -translate-x-1/2">
<div ref={ref} className="relative left-1/2 w-screen -translate-x-1/2 m-0">

Just this little change to remove the white space between banners and we should be good to go!

Copy link
Contributor

@rebeccahongsf rebeccahongsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving since this approach makes sense to me 🫡
Thank you for putting this solution together, @pookmish!

@pookmish
Copy link
Contributor Author

FWIW, I showed this to the client and she said to hold on it for now

@pookmish pookmish closed this Oct 31, 2024
@pookmish pookmish deleted the remove-force-full-width branch October 31, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants