SUM-198 | fixup footer logo border; adjust testimonial pill; update stanford font import #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rebeccahongsf
commented
Sep 19, 2024
| @@ -13,8 +13,8 @@ const PageFooter = ({...props}: Props) => { | |||
| <div className="bg-cardinal-red py-10 [&_a:hocus]:text-white [&_a]:text-white [&_a]:no-underline"> | |||
| <div className="centered lg:flex lg:items-start lg:gap-20"> | |||
| <div className="mb-10 text-center"> | |||
| <a className="text-center font-stanford" href="https://www.stanford.edu"> | |||
| <div className="text-[3.2rem]">Stanford</div> | |||
| <a className="logo text-center text-[3.4rem]" href="https://www.stanford.edu"> | |||
There was a problem hiding this comment.
Util class logo from decanter contains everything we need for the Stanford branding things.
.logo {
display: inline-block;
font-family: Stanford, "Source Serif Pro", Georgia, Times, "Times New Roman", serif;
font-weight: 400;
line-height: 0.75;
text-decoration: none;
text-transform: none;
transform: translateZ(0);
font-style: normal;
font-variant: normal;
letter-spacing: 0;
color: #8C1515;
font-feature-settings: "liga" 1;
font-variant-ligatures: discretionary-ligatures;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
}
.logo:focus {
color: #8C1515;
}
.logo:hover {
color: #8C1515;
}
We only need to add stanford: ['var(--font-stanford)', 'sans-serif'] to the Tailwind config if we want to use font-stanford elsewhere.
There was a problem hiding this comment.
I'm good with that. But now we need to change the font size on the line "University" in the footer. Also the hover color needs changed.
pookmish
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Review By (Date)
Review Tasks
Setup tasks and/or behavior to test
Associated Issues and/or People