Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nojira | @rebeccahongsf | fixup action-link className #6

Merged
merged 2 commits into from
May 7, 2024

Conversation

rebeccahongsf
Copy link
Contributor

READY FOR REVIEW

Summary

  • The className prop was not being passed into the ActionLink component
  • When initially passing in the prop, a loop occurs because of the link--action class

Review By (Date)

  • When possible

Urgency

  • How urgent is this? (Normal, High)

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Create a media with image with a link
  3. Add a color class to the link in media-caption-paragraph.tsx (e.g. link--action text-cardinal-red)
  4. Confirm that the action link reflects the correct color
  5. Review code 🪴

@rebeccahongsf rebeccahongsf requested a review from pookmish May 2, 2024 22:59
@pookmish
Copy link
Contributor

pookmish commented May 3, 2024

Looks like it's still looping infinitely

@pookmish pookmish merged commit 7d014c6 into 1.x May 7, 2024
1 check passed
@pookmish pookmish deleted the feature/nojira--actionLinkClass branch May 7, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants