8.5.6

- D8CORE-2008: Removing the secondary skip link when the hamburger visible (#229) (45ee657)
- D8CORE-2494 Add "Back to Top" button (#230) (ceb0563)

.circleci/config.yml

@@ -1,43 +1,46 @@
-version: 2
-# CircleCI integration with Drupal 8.
-
-## Defines images and working directory.
-defaults: &defaults
-  docker:
-    - image: pookmish/drupal8ci:pcov
-    - image: selenium/standalone-chrome:3.141.59-neon
-    - image: mariadb:10.3
-      environment:
-        MYSQL_ALLOW_EMPTY_PASSWORD: 1
-  working_directory: /var/www/html
-
-#Jobs
-
-back_to_dev: &back_to_dev
-  <<: *defaults
-  steps:
-    - checkout
-    - run:
-        name: Back to dev
-        command: |
-          composer global require SU-SWS/stanford-caravan:dev-8.x-1.x
-          ~/.composer/vendor/bin/sws-caravan back-to-dev ${CIRCLE_TAG} ${CIRCLE_WORKING_DIRECTORY}
-
-# Declare all of the jobs we should run.
-jobs:
-  run-back-to-dev:
-    <<: *back_to_dev
-
-# Declare a workflow that runs all of our jobs in parallel.
-workflows:
-  version: 2
-  after_release:
-    jobs:
-      - run-back-to-dev:
-          filters:
-            tags:
-              only:
-                - /^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*).*?$/
-            branches:
-              ignore:
-                - /.*/
+version: 2
+# CircleCI integration with Drupal 8.
+
+## Defines images and working directory.
+defaults: &defaults
+  docker:
+    - image: pookmish/drupal8ci:latest
+    - image: selenium/standalone-chrome:latest
+    - image: circleci/mysql:5.7
+      environment:
+        MYSQL_DATABASE: drupal
+        MYSQL_USER: drupal
+        MYSQL_PASSWORD: drupal
+        MYSQL_ALLOW_EMPTY_PASSWORD: 1
+  working_directory: /var/www/html
+
+#Jobs
+
+back_to_dev: &back_to_dev
+  <<: *defaults
+  steps:
+    - checkout
+    - run:
+        name: Back to dev
+        command: |
+          composer global require SU-SWS/stanford-caravan:dev-8.x-1.x
+          ~/.composer/vendor/bin/sws-caravan back-to-dev ${CIRCLE_TAG} ${CIRCLE_WORKING_DIRECTORY}
+
+# Declare all of the jobs we should run.
+jobs:
+  run-back-to-dev:
+    <<: *back_to_dev
+
+# Declare a workflow that runs all of our jobs in parallel.
+workflows:
+  version: 2
+  after_release:
+    jobs:
+      - run-back-to-dev:
+          filters:
+            tags:
+              only:
+                - /^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*).*?$/
+            branches:
+              ignore:
+                - /.*/

.github/pull_request_template.md

@@ -1,4 +1,4 @@
-# READY FOR REVIEW/NOT READY
+# NOT READY FOR REVIEW
 - (Edit the above to reflect status)
 
 # Summary
@@ -7,23 +7,60 @@
 # Review By (Date)
 - When does this need to be reviewed by?
 
+# Criticality
+- How critical is this PR on a 1-10 scale? Also see [Severity Assessment](https://stanfordits.atlassian.net/browse/D8CORE-1705).
+- E.g., it affects one site, or every site and product?
+
 # Urgency
-- How critical is this PR?
+- How urgent is this? (Normal, High)
+
+# Review Tasks
+
+## Setup tasks and/or behavior to test
+
+1. Check out this branch
+2. Rebuild Cache and import config `drush cr ; drush ci`
+3. Navigate to...
+4. Verify...
+
+### Site Configuration Sync
+
+- Is there a config:export in this PR that changes the config sync directory?
+
+## Front End Validation
+- [ ] Design is approved by @ user?
+- [ ] HTML validation: Is the markup using the appropriate semantic tags and [passes validation](https://validator.w3.org/nu/)? Or, [QA request ticket created](https://github.com/SU-SWS/template_warehouse/blob/master/jira_templates/QA_request_template.txt)?
+- [ ] Cross-browser testing: Has been performed? Or, [QA request ticket created](https://github.com/SU-SWS/template_warehouse/blob/master/jira_templates/QA_request_template.txt)?
+- [ ] Automated accessibility: Scans performed? Or, [QA request ticket created](https://github.com/SU-SWS/template_warehouse/blob/master/jira_templates/QA_request_template.txt)?
+- [ ] Manual accessibility: Manually tested? Or, [QA request ticket created](https://github.com/SU-SWS/template_warehouse/blob/master/jira_templates/QA_request_template.txt)?
+
+## Backend / Functional Validation
+### Code
+- [ ] Are the naming conventions following our standards?
+- [ ] Does the code have sufficient inline comments?
+- [ ] Is there anything in this code that would be hidden or hard to discover through the UI?
+- [ ] Are there any [code smells](https://blog.codinghorror.com/code-smells/)?
+- [ ] Are tests provided? eg (unit, behat, or codeception)
 
-# Steps to Test
+### Code security
+- [ ] Are all [forms properly sanitized](https://www.drupal.org/docs/8/security/drupal-8-sanitizing-output)?
+- [ ] Any obvious [security flaws or new areas for attack](https://www.drupal.org/docs/8/security)?
 
-1. Do this
-1. Then this
-2. Then this
+## General
+- [ ] Is there anything included in this PR that is not related to the problem it is trying to solve?
+- [ ] Is the approach to the problem appropriate?
 
 # Affected Projects or Products
 - Does this PR impact any particular projects, products, or modules?
 
 # Associated Issues and/or People
-- JIRA ticket
+- JIRA ticket(s)
 - Other PRs
 - Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
 - Anyone who should be notified? (`@mention` them here)
 
-# See Also
-- [PR Checklist](https://gist.github.com/sherakama/0ba17601381e3adbe0cad566ad4d80a5)
+# Resources
+- [AMP Tool](https://stanford.levelaccess.net/index.php)
+- [Accessibility Manual Test Script](https://docs.google.com/document/d/1ZXJ9RIUNXsS674ow9j3qJ2g1OAkCjmqMXl0Gs8XHEPQ/edit?usp=sharing)
+- [HTML Validator](https://validator.w3.org/)
+- [Browserstack](https://live.browserstack.com/dashboard) and link to [Browserstack Credentials](https://asconfluence.stanford.edu/confluence/display/SWS/External+Account+Credentials)

CHANGELOG.md

@@ -1,5 +1,12 @@
 # Stanford Basic Theme
 
+8.x-5.6
+--------------------------------------------------------------------------------
+_Release Date: 2021-06-11_
+
+- D8CORE-2008: Removing the secondary skip link when the hamburger visible (#229) (45ee657)
+- D8CORE-2494 Add "Back to Top" button (#230) (ceb0563)
+
 8.x-5.5
 --------------------------------------------------------------------------------
 _Release Date: 2021-05-07_