SUP-192 | @rebeccahongsf | update media caption link styles #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccahongsf
commented
May 2, 2024
| }, | ||
| colors: { | ||
| 'press-indigo': '#003D69', | ||
| 'press-grass': '#00593E', |
There was a problem hiding this comment.
FYI: I stand corrected on this. I must've tested it incorrectly since the way @jenbreese had this configured originally before I made these changes in PR #5 was correct! 😃
There was a problem hiding this comment.
How about adding "Magenta" and "Steel" while we're here?
There was a problem hiding this comment.
I was able to locate the new colors press-sand and press-bay-light-light. Do you know where I can find the Magenta and Steel hex codes?
There was a problem hiding this comment.
No idea. We'll come back to it
pookmish
requested changes
May 2, 2024
| }, | ||
| colors: { | ||
| 'press-indigo': '#003D69', | ||
| 'press-grass': '#00593E', |
There was a problem hiding this comment.
How about adding "Magenta" and "Steel" while we're here?
|
FYI: I'm looking into the lint error 👀 |
pookmish
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Review By (Date)
Review Tasks
Setup tasks and/or behavior to test
Site Configuration Sync
Front End Validation
Associated Issues and/or People