Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the airtable-list-builder.js file that was moved to a new location #31

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

redndahead
Copy link
Contributor

READY FOR REVIEW

Summary

  • A file was missing from the last PR

Review By (Date)

  • When does this need to be reviewed by? ASAP

Criticality

  • How critical is this PR on a 1-10 scale? 7

Urgency

  • How urgent is this? (Normal, High) Normal

Review Tasks

Setup tasks and/or behavior to test

None

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory? No

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@buttonwillowsix buttonwillowsix self-requested a review February 22, 2024 13:28
@buttonwillowsix buttonwillowsix merged commit 46ce0b7 into SU-SWS:main Feb 22, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants