Relayout of Training/Workshops and Service Catalog #23

redndahead · 2024-01-10T22:13:16Z

READY FOR REVIEW

Summary

RHW-37: Make the Snaplogic URL configurable in the theme settings. and this
RHW-38: Allow multi-tagging categories and series for one training event
RHW-39: Turn categories and series on an event entry into clickable filters
RHW-40: Add a search box for training and workshop events
RHW-41: Turn on filters on Upcoming Events page
RHW-42: Make "Training and Workshops" page display full-width
RHW-45: For Training & Workshops page, add an anchor link for each card
RHW-47: Modify CSS for Training & Workshops page and this
RHW-48: Allow multi-selecting categories and series
RHW-49: Theme single-select and multi-select filters
RHW-50: Style Airtable filter tags on training cards

Review By (Date)

When does this need to be reviewed by? Whenever is good for you

Criticality

How critical is this PR on a 1-10 scale? 5

Urgency

How urgent is this? (Normal, High) Normal

Review Tasks

See above

Setup tasks and/or behavior to test

None

Site Configuration Sync

Is there a config:export in this PR that changes the config sync directory? None

Front End Validation

Design is approved by @ user?
HTML validation: Is the markup using the appropriate semantic tags and passes validation? Or, QA request ticket created?
Cross-browser testing: Has been performed? Or, QA request ticket created?
Automated accessibility: Scans performed? Or, QA request ticket created?
Manual accessibility: Manually tested? Or, QA request ticket created?

Backend / Functional Validation

Code

Are the naming conventions following our standards?
Does the code have sufficient inline comments?
Is there anything in this code that would be hidden or hard to discover through the UI?
Are there any code smells?
Are tests provided? eg (unit, behat, or codeception)

Code security

Are all forms properly sanitized?
Any obvious security flaws or new areas for attack?

General

Is there anything included in this PR that is not related to the problem it is trying to solve?
Is the approach to the problem appropriate?

Affected Projects or Products

Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

JIRA ticket(s)
Other PRs
Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
Anyone who should be notified? (@mention them here)

Resources

AMP Tool
Accessibility Manual Test Script
HTML Validator
Browserstack and link to Browserstack Credentials

Initial change to have a script create default content.

…run new script.

Add default content

RHW-37: Make the SnapLogic URL Configurable

…ert variables to lowercase and hyphens.

RHW-37: Add support for accessing main results using $ in token. Conv…

…s. Update service catalog to support the search and new filter handling.

RHW 40: Provided support for search in airtable lists.

…rl as the filters change.

RHW-45: Allow predefined values through the filter. Also update the url as the filters change.

RHW-42: Add a single page for all the training.

RHW-47: Theme filters.

sherakama · 2024-01-11T17:38:52Z

src/js/airtable-list-builder.js

@@ -358,4 +502,19 @@
    $('#airtable-list').height(newTop);
  }

+  // debounce so filtering doesn't happen every millisecond
+  function debounce( fn, threshold ) {


Drupal has a debounce https://drupaljs.net/10.0.x/debounce.js.html

Ehh Good point. This is probably a future improvement.

sherakama · 2024-01-11T17:41:44Z

@redndahead I see a bunch of A11y stuff in here so thank you for that but a quick question for you. Has this functionality gone through a SODA review?

redndahead · 2024-01-11T20:54:49Z

@redndahead I see a bunch of A11y stuff in here so thank you for that but a quick question for you. Has this functionality gone through a SODA review?

No we have not done that.

sherakama · 2024-01-11T22:16:53Z

@redndahead I see a bunch of A11y stuff in here so thank you for that but a quick question for you. Has this functionality gone through a SODA review?

No we have not done that.

Ok, I'm not going to make that a requirement for this for approval or anything but with the interactivity it would be good to get their eyes on this. We can request a review once there is a live URL for them.

sherakama · 2024-01-11T22:17:23Z

I'll continue to review this shortly.

…dd a default color

sherakama

Approving.

@jenbreese do you want to take a pass as well?

Also, I'd like to get this submitted to SODA for review. Once it is up on the test site, let's submit a ticket for them to have a pass on the service-catalog page.

RHW-52: Add support for adding classes to arrays through the config.

jenbreese · 2024-01-17T23:07:03Z

@redndahead I think it looks good. I noticed you have commented out some css and left it in. I would suggest removing it since it will be in the repo anyway if you need it later.

RHW-50: Style filter tag on Training and Service Catalog pages

redndahead · 2024-02-03T03:34:29Z

I have another PR I need to send over. Since this has already been reviewed would you like to merge this and then my next PR will only have a couple of changes?

sherakama · 2024-02-05T17:28:50Z

I have another PR I need to send over. Since this has already been reviewed would you like to merge this and then my next PR will only have a couple of changes?

Smaller PRs are preferred. You can merge this and open another one or PR stack on top of this.

redndahead · 2024-02-05T22:38:51Z

@sherakama @jenbreese I can't merge this PR as I don't have the permissions. Can you merge it and then I'll send over another PR.

buttonwillowsix · 2024-02-06T04:30:12Z

@redndahead if you want to merge this, you can resolve the conflicts and I can take care of it!

redndahead · 2024-02-13T04:44:14Z

@sherakama @jenbreese I have resolved the conflicts. Please merge and deploy as soon as possible please.

sherakama · 2024-02-13T19:27:52Z

Thanks @redndahead going ahead with the merge.

Do we have a test environment or does this get deployed straight to production?

cdchangr · 2024-02-13T19:34:14Z

Hi @sherakama,
@redndahead is out today, so I am jumping in. Our test site is: https://researchhubsubtheme.sites.stanford.edu/
Thanks very much!

redndahead and others added 30 commits November 1, 2023 14:00

Create set-default-content.php

c63bac1

Initial change to have a script create default content.

Move external link to default content script.

c52e0da

Move creation of external link to script and use drush php-script to …

b7c2b92

…run new script.

Add beginning php tag.

3099e98

Fix missing prefixes.

b4c144e

Add support for displaying trainings.

de4ec4c

Create special menu for airtable.

1867b31

Fix creating submenus for airtable

d4e8d85

Enable person.

7289a0d

Move php code to set-default-content.php

9c3f414

Merge pull request #29 from gsb-library/add-default-content

db4380c

Add default content

RHW-37: Make the Snaplogic URL Configurable.

27b4ad2

RHW-37: Add missing theme-settings.php file.

0114b1a

Merge pull request #30 from gsb-library/RHW-37

d9c5524

RHW-37: Make the SnapLogic URL Configurable

RHW-37: Add support for accessing main results using $ in token. Conv…

557ee72

…ert variables to lowercase and hyphens.

Merge pull request #31 from gsb-library/RHW-37

dae3b98

RHW-37: Add support for accessing main results using $ in token. Conv…

RHW-40: Rewrite filter handling to support search and additional need…

d37cf36

…s. Update service catalog to support the search and new filter handling.

RHW-40: Add search support for past and upcoming trainings.

6cb7abd

Merge pull request #32 from gsb-library/RHW-40

fb0d84d

RHW 40: Provided support for search in airtable lists.

RHW-45: Allow predefined values through the filter. Also update the u…

80d0426

…rl as the filters change.

Merge pull request #33 from gsb-library/RHW-45

7b356af

RHW-45: Allow predefined values through the filter. Also update the url as the filters change.

Fix errors if you add an empty wysiwyg paragraph.

f994128

RHW-42: Add all training page.

6fcce2e

Merge pull request #34 from gsb-library/RHW-42

3ada4f4

RHW-42: Add a single page for all the training.

Modify Airtable filters, search, upcoming label

326af85

Modify Training page mobile display

4661e6e

Set min-width for cards on mobile devices

a197e2e

Merge pull request #35 from gsb-library/RHW-47

d478b0f

RHW-47: Theme filters.

Modify filters, the search box for Service Catalog

0b94848

RHW-48: Add chosen library to allow multiple filters.

8927462

sherakama reviewed Jan 11, 2024

View reviewed changes

Assign colors to RH units; change filter tag colors to unit colors; a…

537558a

…dd a default color

sherakama approved these changes Jan 17, 2024

View reviewed changes

redndahead added 2 commits January 17, 2024 20:49

RHW-52: Add support for adding classes to arrays through the config.

ca3fb65

Merge pull request #42 from gsb-library/RHW-52

fa7fe17

RHW-52: Add support for adding classes to arrays through the config.

cdchangr and others added 9 commits January 18, 2024 05:27

Create a sepeerate scss for core units; modify training tag code

7b0ec7c

Start tracking webpack-assets.json

9d1edef

RHW-52: Add support for adding classes to arrays through the config.

8d2ff7e

Start tracking webpack-assets.json

c7c423f

Increase the specificity of the core unit CSS rule

b4522de

Modify DAG unit and tag colors; Update category filter data source

01abd9d

Modify training date format display

b8e5d9e

Clean up color tag code for training and service catalog

6c56fdc

Merge pull request #43 from gsb-library/RHW-50

988cb2e

RHW-50: Style filter tag on Training and Service Catalog pages

buttonwillowsix self-assigned this Feb 6, 2024

buttonwillowsix removed the request for review from jenbreese February 6, 2024 04:30

Merge branch 'main' into main

7b66499

sherakama merged commit 717fadd into SU-SWS:main Feb 13, 2024
1 check failed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Relayout of Training/Workshops and Service Catalog #23

Relayout of Training/Workshops and Service Catalog #23

redndahead commented Jan 10, 2024

sherakama Jan 11, 2024

redndahead Jan 11, 2024

sherakama commented Jan 11, 2024

redndahead commented Jan 11, 2024

sherakama commented Jan 11, 2024

sherakama commented Jan 11, 2024

sherakama left a comment

jenbreese commented Jan 17, 2024

redndahead commented Feb 3, 2024

sherakama commented Feb 5, 2024 •

edited

Loading

redndahead commented Feb 5, 2024

buttonwillowsix commented Feb 6, 2024

redndahead commented Feb 13, 2024

sherakama commented Feb 13, 2024

cdchangr commented Feb 13, 2024

Relayout of Training/Workshops and Service Catalog #23

Relayout of Training/Workshops and Service Catalog #23

Conversation

redndahead commented Jan 10, 2024

READY FOR REVIEW

Summary

Review By (Date)

Criticality

Urgency

Review Tasks

Setup tasks and/or behavior to test

Site Configuration Sync

Front End Validation

Backend / Functional Validation

Code

Code security

General

Affected Projects or Products

Associated Issues and/or People

Resources

sherakama Jan 11, 2024

Choose a reason for hiding this comment

redndahead Jan 11, 2024

Choose a reason for hiding this comment

sherakama commented Jan 11, 2024

redndahead commented Jan 11, 2024

sherakama commented Jan 11, 2024

sherakama commented Jan 11, 2024

sherakama left a comment

Choose a reason for hiding this comment

jenbreese commented Jan 17, 2024

redndahead commented Feb 3, 2024

sherakama commented Feb 5, 2024 • edited Loading

redndahead commented Feb 5, 2024

buttonwillowsix commented Feb 6, 2024

redndahead commented Feb 13, 2024

sherakama commented Feb 13, 2024

cdchangr commented Feb 13, 2024

sherakama commented Feb 5, 2024 •

edited

Loading