Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new test: very big tchunk #6620

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JiakunYan
Copy link
Contributor

add a new test to cover the bug fixed by #6619

Split #6619 into two PRs to speed-up its merging.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.57% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (62d92ad) 237187 203187 85.67%
Head commit (9bf6953) 192995 (-44192) 164231 (-38956) 85.10% (-0.57%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6620) 36 36 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

# Disable the test for very_big_parcel due to limited CircleCI resources
if(${test} STREQUAL "very_big_parcel")
continue()
endif()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to add an exclusion here: https://github.com/STEllAR-GROUP/hpx/blob/master/.circleci/config.yml#L706?

@hkaiser
Copy link
Member

hkaiser commented Feb 24, 2025

@JiakunYan please fix the CI failures before this can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants