-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Removed extra space between rule content and Giscus #1669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to create a class for this.
See https://www.ssw.com.au/rules/avoid-unnecessary-css-classes/
- Please remove the new class you created
- Change the existing Tailwind "mb-2" class to be "mb-6" (we'll get the same result 😉)
Hi @tiagov8, Removed custom margin styling and used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tiagov8
✅ Done |
As per email from Adam: "Giscus space".
Changes:
This space is not from Giscus container, instead there is
<section>
container with no data inside between rule content and Giscus which was rendering extra space with thin line.As per my conversation with @tiagov8, kept thin line for better UI, and reduced the top and bottom margin.
Figure: Empty container which was rendering space
Figure: ❌ Before - there is extra space after rule content and Giscus
Figure: ✅ After - the space is reduced and thin line was kept between rule content and Giscus