Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added Profile page with Bookmarks #1657

Merged
merged 10 commits into from
Dec 19, 2024
Merged

✨ Added Profile page with Bookmarks #1657

merged 10 commits into from
Dec 19, 2024

Conversation

babakamyljanovssw
Copy link
Member

@babakamyljanovssw babakamyljanovssw commented Dec 12, 2024

Relates to #1580

  • Added Profile page with Bookmarks tab

image
Figure: Link to User profile page

image
Figure: Bookmarks tab

image
Figure: Mobile view

@babakamyljanovssw babakamyljanovssw changed the title ✨ DRAFT - Added Bookmarks page ✏️ DRAFT - Added Bookmarks page Dec 12, 2024
@babakamyljanovssw babakamyljanovssw changed the title ✏️ DRAFT - Added Bookmarks page ✨ Added Profile page with Bookmarks Dec 16, 2024
@babakamyljanovssw babakamyljanovssw marked this pull request as ready for review December 16, 2024 05:11
@tiagov8
Copy link
Member

tiagov8 commented Dec 17, 2024

cc @jaydenalchin @bettybondoc

Hi @babakamyljanovssw

Note: This view is also on JD's Rules V2 redesign: https://www.figma.com/design/MZsibMztRkZiCQBsKM66d8/SSW-Rules-v2?node-id=0-1829&t=s6hTydamfX2budMu-1

On the 1st screenshot

  • 1. Change from "Manage GitHub Account" to "GitHub Profile"
  • 2. Change from "Your Profile" to "SSW Rules Profile"
  • 3. Move the GitHub Profile to be a link as the other 2... larger icon and in grey

It will look like this:

Screenshot 2024-12-17 at 9 57 05 AM

On the the 2nd and 3rd images:

  • 4. Change from "{{ ICON }} GitHub Account" to "{{ ICON }} GitHub Profile"

On the 3rd image (mobile):

  • 5. Please remove the bottom padding below the red line... under the Bookmarks tab

Question:

  1. In the bookmarks view.. I assume if you click the little bookmark icon on the right, it gives you a way to remove it from bookmarks... is that true?

@babakamyljanovssw
Copy link
Member Author

Hey @tiagov8

Thanks for feedback, all task done. Please check out new images below.

image
Figure: Dropdown

image
Figure: SSW.Rules Profile | Bookmarks (Desktop view)

image
Figure: SSW.Rules Profile | Bookmarks (Mobile view)

  1. In the bookmarks view.. I assume if you click the little bookmark icon on the right, it gives you a way to remove it from bookmarks... is that true?

Yes, when clicking the bookmark icon will remove the rule and update the list

074E08D3-8775-4A33-9617-28B5F9E314E9
Figure: Removing bookmarked rule

Copy link
Member

@tiagov8 tiagov8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test pass ✅

@babakamyljanovssw babakamyljanovssw merged commit f39c3fc into main Dec 19, 2024
5 checks passed
@babakamyljanovssw babakamyljanovssw deleted the 1580-bookmarks branch December 19, 2024 01:07
@babakamyljanovssw babakamyljanovssw linked an issue Dec 19, 2024 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Add Profile page with Bookmarks tab
2 participants