✨ [Feat] 카카오 소셜 로그인 구현 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Backend into issue/38-kakao-login # Conflicts: # src/main/java/ssuPlector/controller/DeveloperController.java
…Backend into issue/38-kakao-login # Conflicts: # build.gradle # src/main/resources/application.yml
…Backend into issue/38-kakao-login # Conflicts: # src/main/java/ssuPlector/domain/Developer.java
Closed
1 task
chanmin-00
approved these changes
May 10, 2024
| @@ -41,8 +42,7 @@ public ApiResponse<String> kakaoLogout( | |||
|
|
|||
| @Operation(summary = "토큰 재발급", description = "토큰을 재발급 합니다._숙희") | |||
| @PostMapping("/kakao/refresh") | |||
| public ApiResponse<TokenRefreshResponse> refresh( | |||
| @RequestParam("refreshToken") String refreshToken) { | |||
| public ApiResponse<TokenRefreshResponse> refresh(@ExtractToken String refreshToken) { | |||
There was a problem hiding this comment.
토큰 발급이랑 추출 방식의 차이가 잘 이해가 되지 않는데 어떤 이유로 바꾼 건가요?
There was a problem hiding this comment.
해당 어노테이션에서는 HTTP 요청 헤더에서 Authorization값을 추출해서 유효한지 체크하고 refreshToken으로 넘기는 과정으로 동작합니다! 그전에는 그냥 리프레시 토큰을 입력받는 형식으로 구성되어있는데, 그것보다 이후의 로직이 좀 더 나은거 같아 수정했습니다 !
Ares-10
approved these changes
May 10, 2024
|
resolveArgument 이 부분에서 developerService.getDeveloper(userId) 사용하는데 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📍 PR 타입
❗️ 관련 이슈 링크
Close #38
🔁 변경 및 추가사항
로그인/로그아웃/리프레시 토큰 발급 컨트롤러 181316e
커스텀 어노테이션
securityConfig 설정 03ae06f
컨트롤러 제네릭 타입 추가 fa19a3a
📚 레퍼런스 (또는 새로 알게 된 내용) 혹은 궁금한 사항들
✅ 체크 리스트