KCM: fix memory leak #7824
Closed
KCM: fix memory leak #7824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The copy of 'secret' argument - `secret_val.data` - was left hanging on `sss_sec_ctx`, effectively resulting in a memory leak. But this copy isn't actually required as this data isn't modified in below operations. This is a backport of SSSD#7823 :fixes:'sssd_kcm' memory leak was fixed.
alexey-tikhonov
force-pushed
the
kcm-mem-leak-2-2.9
branch
from
22c2d4c to
2c80bf7
Compare
justin-stephenson
approved these changes
Feb 6, 2025
alexey-tikhonov
added
Accepted
Ready to push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copy of 'secret' argument -
secret_val.data- was left hanging onsss_sec_ctx, effectively resulting in a memory leak. But this copy isn't actually required as this data isn't modified in below operations.This is a backport of #7823
:fixes:'sssd_kcm' memory leak was fixed.