-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Fix gating test for tier1 #7780
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the permission of snippet file
I don't have further comments and will leave somebody else from QE to review this. |
spoore1
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ran a test job to confirm and all config tests are passing:
2024-12-20T16:57:01 =========================== short test summary info ============================
2024-12-20T16:57:01 PASSED src/tests/multihost/alltests/test_config_merging.py::TestConfigMerge::test_0001_verifypermission
2024-12-20T16:57:01 PASSED src/tests/multihost/alltests/test_config_merging.py::TestConfigMerge::test_0002_hiddenfiles
2024-12-20T16:57:01 PASSED src/tests/multihost/alltests/test_config_merging.py::TestConfigMerge::test_0003_lastreadparameter
2024-12-20T16:57:01 PASSED src/tests/multihost/alltests/test_config_merging.py::TestConfigMerge::test_0004_formatsnippetfile
2024-12-20T16:57:01 PASSED src/tests/multihost/alltests/test_config_merging.py::TestConfigMerge::test_0005_ownershisnippetfile
2024-12-20T16:57:01 PASSED src/tests/multihost/alltests/test_config_merging.py::TestConfigMerge::test_0006_bz1372258
2024-12-20T16:57:01 PASSED src/tests/multihost/alltests/test_config_merging.py::TestConfigMerge::test_0007_bz1466503
2024-12-20T16:57:01 PASSED src/tests/multihost/alltests/test_config_merging.py::TestConfigMerge::test_0008_bz1466503
2024-12-20T16:57:01 PASSED src/tests/multihost/alltests/test_config_merging.py::TestConfigMerge::test_0009_bz1666307
2024-12-20T16:57:01 PASSED src/tests/multihost/alltests/test_config_merging.py::TestConfigMerge::test_0010_bz1723273
2024-12-20T16:57:01 ========== 10 passed, 250 deselected, 2 warnings in 479.39s (0:07:59) ==========
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix gating test for tier1