Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing sys/types.h on musl libc #7769

Closed
wants to merge 1 commit into from
Closed

Fix missing sys/types.h on musl libc #7769

wants to merge 1 commit into from

Conversation

fossdd
Copy link
Contributor

@fossdd fossdd commented Dec 16, 2024

Fixes 0344c41

@alexey-tikhonov
Copy link
Member

Could you please add to the commit message the reason why is 'sys/types.h' needed?

@fossdd
Fix missing include sys/types.h
64a4a48 
ino_t is provided by <sys/types.h>, see sys_types.h(0p). And therefore
build fails on musl libc and probably other libcs.

	src/sss_client/nss_mc.h:56:5: error: unknown type name 'ino_t';

fixes commit 0344c41 (SSS_CLIENT: check if mem-cache fd was hijacked)
@fossdd
Copy link
Contributor Author

fossdd commented Dec 16, 2024 •
edited
Loading

Could you please add to the commit message the reason why is 'sys/types.h' needed?

Sure, amended the commit.

commit 64a4a48948bb59239d9ee0a7b770dfa31a935a16 (HEAD -> missing-types-h, origin/missing-types-h)
Author: fossdd <[email protected]>
Date:   Mon Dec 16 16:56:34 2024 +0100

    Fix missing include sys/types.h
    
    ino_t is provided by <sys/types.h>, see sys_types.h(0p). And therefore
    build fails on musl libc and probably other libcs.
    
            src/sss_client/nss_mc.h:56:5: error: unknown type name 'ino_t';
    
    fixes commit 0344c41aca0d (SSS_CLIENT: check if mem-cache fd was hijacked)

@alexey-tikhonov
Copy link
Member

https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html

ACK

@alexey-tikhonov alexey-tikhonov self-assigned this Dec 16, 2024
@alexey-tikhonov
Copy link
Member

Pushed PR: #7769

  • master
    • 91d8199 - Fix missing include sys/types.h
  • sssd-2-10
    • 6098cfc - Fix missing include sys/types.h
  • sssd-2-9
    • ec174a0 - Fix missing include sys/types.h

@fossdd
Copy link
Contributor Author

fossdd commented Jan 6, 2025

Thank you!

@fossdd fossdd deleted the missing-types-h branch January 6, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-tikhonov alexey-tikhonov alexey-tikhonov approved these changes

Assignees

@alexey-tikhonov alexey-tikhonov

Labels
branch: sssd-2-9 branch: sssd-2-10 Pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fossdd @alexey-tikhonov