ad: avoid printing backtrace on certain conditions #7035
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/providers/ad/ad_gpo.c
Outdated
| @@ -3435,7 +3435,7 @@ ad_gpo_get_som_attrs_done(struct tevent_req *subreq) | |||
| goto done; | |||
| } | |||
| if ((num_results < 1) || (results == NULL)) { | |||
| DEBUG(SSSDBG_OP_FAILURE, "no attrs found for SOM; try next SOM.\n"); | |||
| DEBUG(SSSDBG_MINOR_FAILURE, "no attrs found for SOM; try next SOM.\n"); | |||
There was a problem hiding this comment.
Does it mean "No GPO was found for given scope of management (SOM)"?
src/providers/ad/ad_gpo.c
Outdated
| @@ -3456,7 +3456,7 @@ ad_gpo_get_som_attrs_done(struct tevent_req *subreq) | |||
| } | |||
|
|
|||
| if ((ret == ENOENT) || (el->num_values == 0)) { | |||
| DEBUG(SSSDBG_OP_FAILURE, "no attrs found for SOM; try next SOM\n"); | |||
| DEBUG(SSSDBG_MINOR_FAILURE, "no attrs found for SOM; try next SOM\n"); | |||
There was a problem hiding this comment.
This message is the same as above and I think this is wrong.
Looking below I guess it should be something like "AD_AT_GPLINK attr not found or has no value"?
|
If those are totally ok and aren't a sign of misconfiguration on server side, I would change to |
This is expected on empty GPOs and we just skip the element. Therefore we should not print backtrace.
pbrezina
force-pushed
the
adbacktrace
branch
from
fe6ab54 to
01fd8cd
Compare
|
Updated. |
alexey-tikhonov
approved these changes
Nov 28, 2023
|
ACK |
alexey-tikhonov
added
Accepted
Ready to push
|
Pushed PR: #7035
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was found by test from #6928.