Tests: alltests/test_ldap_extra_attrs.py converted #6977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
patriki01
force-pushed
the
extra_attributes
branch
from
d7eb96f to
ee26e58
Compare
patriki01
force-pushed
the
extra_attributes
branch
2 times, most recently
from
45a517e to
f5204be
Compare
patriki01
force-pushed
the
extra_attributes
branch
2 times, most recently
from
112fb2e to
9eb98d1
Compare
|
I corrected my code for next round. @justin-stephenson |
patriki01
force-pushed
the
extra_attributes
branch
from
9eb98d1 to
6b11d88
Compare
Okay let's wait for SSSD/sssd-test-framework#56 then re-run CI here before approving. |
|
Blocking PR merged, rerunning this one |
patriki01
force-pushed
the
extra_attributes
branch
from
6b11d88 to
5bb1e60
Compare
|
@justin-stephenson CI is green. I think that failures are unrelated. Can we proceed? |
justin-stephenson
approved these changes
Nov 14, 2023
pbrezina
reviewed
Nov 28, 2023
Comment on lines
195
to
243
| def test_ldap_extra_attrs__thread_issue(client: Client, provider: GenericProvider): | ||
| """ | ||
| :title: Thread issue can cause the application to not get any identity information | ||
| :setup: | ||
| 1. Create new user "user1" | ||
| 2. Edit config - "use_fully_qualified_names" to "false" | ||
| 3. Start SSSD | ||
| :steps: | ||
| 1. Start new thread with provided function | ||
| 2. Main thread waits for worker and then sleeps | ||
| 3. Worker is in loop calling getpwuid() | ||
| 4. Main thread cancel worker thread (with exit_flag.set()) | ||
| 5. Thread join | ||
| 6. Call getpwuid() | ||
| :expectedresults: | ||
| 1. Thread is started | ||
| 2. Success | ||
| 3. Success | ||
| 4. Worker is cancelled | ||
| 5. Thread is joined | ||
| 6. Call is not stucked | ||
| :customerscenario: True | ||
| """ | ||
|
|
||
| def worker(): | ||
| nonlocal started, exit_flag | ||
| uid = os.geteuid() | ||
| started.set() | ||
| while not exit_flag.is_set(): | ||
| pwd.getpwuid(uid) | ||
|
|
||
| provider.user("user1").add() | ||
| client.sssd.domain["use_fully_qualified_names"] = "false" | ||
| client.sssd.start() | ||
|
|
||
| started = threading.Event() | ||
| exit_flag = threading.Event() | ||
|
|
||
| thread = threading.Thread(target=worker) | ||
| thread.start() | ||
|
|
||
| started.wait() | ||
| time.sleep(3) | ||
|
|
||
| exit_flag.set() | ||
| thread.join() | ||
|
|
||
| pw = pwd.getpwuid(os.geteuid()) | ||
| assert pw.pw_name, "pwd.getpwuid() call did not return anything" |
There was a problem hiding this comment.
I don't think this tests anything.
- python threads are only simulated, they are not real threads
- all code here is executed on the localhost not on the client (both threads and getpwuid)
pbrezina
requested changes
Nov 28, 2023
|
For now, you can remove this test case from this PR so it can be pushed - please, resolve conflicts. You can handle it on different pull request. |
patriki01
force-pushed
the
extra_attributes
branch
from
5bb1e60 to
be4a562
Compare
|
I resolved the conflicts (Changed the name of the file) and removed last test. Now it is ready |
| import os | ||
| import pwd | ||
| import threading | ||
| import time |
Check notice
Code scanning / CodeQL
Unused import Note test
patriki01
force-pushed
the
extra_attributes
branch
from
be4a562 to
6ab441a
Compare
pbrezina
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: SSSD/sssd-test-framework#56