-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and improvements for package installation during image builds #77
Open
dpward
wants to merge
26
commits into
SSSD:master
Choose a base branch
from
dpward:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
50eeca5
packages: Restore separate block for client base image tasks in Ubuntu
dpward d3aa604
packages: Only run installation tasks when creating base images
dpward 640ac6f
packages: Make tasks for client base image consistent
dpward 89ad3e7
packages: Make tasks for client development image consistent
dpward 4488a74
packages: Fix configuration of backports repository in Debian
dpward 3f1e76a
packages: Only update apt cache when needed
dpward 8d9702c
facts: Import tasks for Debian into Ubuntu
dpward 791df6e
packages: Import tasks for Debian into Ubuntu
dpward b8163fe
packages: Enable GPG signature check for base RPM repositories
dpward 551db92
packages: Remove set_fact task for extended_packageset
dpward 63aa542
packages: Remove unneeded test for dnf.conf
dpward e684f50
packages: Modify dnf.conf in ground base image only
dpward d0513fe
packages: Remove redundant task to install core DNF plugins in CentOS
dpward a049403
packages: Fix configuration of additional repositories in CentOS and …
dpward 8d3ce4d
packages: Use yum_repository module to configure CentOS buildroot
dpward b0e2cd0
facts: Consolidate tasks for CentOS 8 and 9
dpward 28dfab3
packages: Consolidate tasks for CentOS 8 and 9
dpward c67ce38
packages: Import tasks for CentOS into RHEL
dpward 8d2ea58
ansible: Replace group variables containing IPA package names
dpward 0e780c4
ansible: Remove unneeded filter plugin
dpward 3996c76
build: Do not remove dnf-5
dpward 4c976ba
build: Stop the base-ground container cleanly
dpward 72c04a5
build: Detect package manager from base image
dpward 5a5da45
build: Re-use package manager cache when creating base images
dpward fd7125b
build: Include both devel images in comment describing layers
dpward ac5cf15
build: Remove obsolete variable from output
dpward File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,2 @@ | ||
- name: 'Include distribution specific tasks [{{ ansible_distribution }} {{ ansible_distribution_major_version }}]' | ||
include_tasks: '{{ include_file }}' | ||
loop_control: | ||
loop_var: include_file | ||
with_first_found: | ||
- files: '{{ ansible_distribution | distro_includes(ansible_distribution_major_version) }}' | ||
- name: 'Include distribution specific tasks [{{ ansible_distribution }}]' | ||
include_tasks: '{{ ansible_distribution }}.yml' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, keep the plugin. It may not be needed now, but it most certainly will be needed in the future.