Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvements for package installation during image builds #77

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
50eeca5
packages: Restore separate block for client base image tasks in Ubuntu
dpward Mar 10, 2024
d3aa604
packages: Only run installation tasks when creating base images
dpward Mar 10, 2024
640ac6f
packages: Make tasks for client base image consistent
dpward Mar 10, 2024
89ad3e7
packages: Make tasks for client development image consistent
dpward Mar 10, 2024
4488a74
packages: Fix configuration of backports repository in Debian
dpward Mar 10, 2024
3f1e76a
packages: Only update apt cache when needed
dpward Mar 10, 2024
8d9702c
facts: Import tasks for Debian into Ubuntu
dpward Mar 10, 2024
791df6e
packages: Import tasks for Debian into Ubuntu
dpward Mar 10, 2024
b8163fe
packages: Enable GPG signature check for base RPM repositories
dpward Mar 10, 2024
551db92
packages: Remove set_fact task for extended_packageset
dpward Mar 10, 2024
63aa542
packages: Remove unneeded test for dnf.conf
dpward Mar 10, 2024
e684f50
packages: Modify dnf.conf in ground base image only
dpward Mar 10, 2024
d0513fe
packages: Remove redundant task to install core DNF plugins in CentOS
dpward Mar 10, 2024
a049403
packages: Fix configuration of additional repositories in CentOS and …
dpward Mar 10, 2024
8d3ce4d
packages: Use yum_repository module to configure CentOS buildroot
dpward Mar 10, 2024
b0e2cd0
facts: Consolidate tasks for CentOS 8 and 9
dpward Mar 10, 2024
28dfab3
packages: Consolidate tasks for CentOS 8 and 9
dpward Mar 10, 2024
c67ce38
packages: Import tasks for CentOS into RHEL
dpward Mar 10, 2024
8d2ea58
ansible: Replace group variables containing IPA package names
dpward Mar 10, 2024
0e780c4
ansible: Remove unneeded filter plugin
dpward Mar 10, 2024
3996c76
build: Do not remove dnf-5
dpward Mar 10, 2024
4c976ba
build: Stop the base-ground container cleanly
dpward Mar 10, 2024
72c04a5
build: Detect package manager from base image
dpward Mar 10, 2024
5a5da45
build: Re-use package manager cache when creating base images
dpward Mar 10, 2024
fd7125b
build: Include both devel images in comment describing layers
dpward Mar 10, 2024
ac5cf15
build: Remove obsolete variable from output
dpward Mar 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions src/ansible/filter_plugins/distro.py

This file was deleted.

8 changes: 2 additions & 6 deletions src/ansible/roles/facts/tasks/main.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,2 @@
- name: 'Include distribution specific tasks [{{ ansible_distribution }} {{ ansible_distribution_major_version }}]'
include_tasks: '{{ include_file }}'
loop_control:
loop_var: include_file
with_first_found:
- files: '{{ ansible_distribution | distro_includes(ansible_distribution_major_version) }}'
- name: 'Include distribution specific tasks [{{ ansible_distribution }}]'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, keep the plugin. It may not be needed now, but it most certainly will be needed in the future.

include_tasks: '{{ ansible_distribution }}.yml'
8 changes: 2 additions & 6 deletions src/ansible/roles/packages/tasks/main.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
- name: 'Include distribution specific package tasks [{{ ansible_distribution }} {{ ansible_distribution_major_version }}]'
include_tasks: '{{ include_file }}'
loop_control:
loop_var: include_file
with_first_found:
- files: '{{ ansible_distribution | distro_includes(ansible_distribution_major_version) }}'
- name: 'Include distribution specific package tasks [{{ ansible_distribution }}]'
include_tasks: '{{ ansible_distribution }}.yml'

- name: 'Clear package manager cache'
shell: |
Expand Down