Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID-198, 194: new layers on frontend #93

Open
wants to merge 6 commits into
base: release3
Choose a base branch
from

Conversation

doejoedoe
Copy link
Collaborator

Added new layers, fixed axes, removed icons

Copy link
Contributor

@lpetrov02 lpetrov02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я не шарю за фронт, но нейминг меня устраивает!

Copy link
Contributor

@AntoxaBarin AntoxaBarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выглядит нормально. Самое главное - протестировать всё: выбор входов, отправка новых параметров. Нужно чтобы это всё работало

@Artem-Goldenberg
Copy link
Contributor

Artem-Goldenberg commented Dec 24, 2023

Screenshot 2023-12-24 at 16 58 37

Можешь Axes number добавить паддинг справа еще плиз.

Ну и блин конечно в идеале еще бы провалидировать чтобы введенные номера осей хотя бы не совпадали между собой, но можно забить

@lpetrov02 lpetrov02 added the do not merge DO NOT MERGE!!!! label Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge DO NOT MERGE!!!!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants