[Feat/#47] 누락된 아이콘 활성화 로직 반영 #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocahs9
approved these changes
Jan 15, 2025
Comment on lines
-9
to
-15
| const extractFirstPath = (): string => { | ||
| const pathName = location.pathname; | ||
| const parts = pathName.split("/"); | ||
| const basePath = `/${parts[1]}`; | ||
|
|
||
| return basePath; | ||
| }; |
There was a problem hiding this comment.
p3) 이거는 살려두면 어떨까요? 나중에 location 이 만약 /main이 아니라 /main/어쩌구 등등 뒤에 붙는 형식이 되면 pathName이 일치하지 않는다고 인식되어 아이콘이 활성화가 되지 않을 수도 있을 것 같아서요!
There was a problem hiding this comment.
아! 확장성 면에서 기존 로직이 좋은거 같아서 해당 브랜치 폭파 완료했습니다 :)
| type="button" | ||
| onClick={() => handleClick(path)} | ||
| className={styles.navItem({ | ||
| state: location.pathname === path, |
There was a problem hiding this comment.
p3) 만약 위에서 언급한 extractFirstPath 를 살린다면 extractFirstPath() === path 같은 방식으로 아이콘 활성화 여부를 결정하면 좋을 것 같습니다 ~
(아니면 extractFirstPath를 리팩토링해서 인자를 받는 형식으로 한다면, extractFirstPath(location.pathname) === path 으로 활성화 여부를 결정해도 좋을 것 같아요!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Related Issues
✅ 작업 리스트
🔧 작업 내용
nav컴포넌트 링크 인식 로직 반영
📣 리뷰어에게 어떠신가요?
번거롭게 해드려 죄송합니다. 머지 과정에서 작업물이 날아간 것 같아서 새로 반영해 두었습니다.
📸 스크린샷 / GIF / Link
2025-01-14.11.11.38.mov