[feature/#12] 공통 아이콘 제작 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyeeum
approved these changes
Jan 10, 2025
.../main/java/com/wearerommies/roomie/presentation/core/designsystem/component/RoomieKeyword.kt
Outdated
Show resolved
Hide resolved
Comment on lines
36
to
49
| Box( | ||
| modifier = modifier | ||
| .background(color = backgroundColor, shape = RoundedCornerShape(size = 4.dp)) | ||
| .noRippleClickable { | ||
| onClick() | ||
| } | ||
| .padding(horizontal = 8.dp, vertical = 4.dp), | ||
| contentAlignment = Alignment.Center | ||
| ) { | ||
| Text( | ||
| text = text, | ||
| style = textStyle | ||
| ) | ||
| } |
There was a problem hiding this comment.
Box 없이 Text만으로도 구현할 수 있어요
modifier을 잘 사용해보셔요! 다른 컴포넌트들도 마찬가지!
.../main/java/com/wearerommies/roomie/presentation/core/designsystem/component/RoomieKeyword.kt
Outdated
Show resolved
Hide resolved
.../main/java/com/wearerommies/roomie/presentation/core/designsystem/component/RoomieKeyword.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/wearerommies/roomie/presentation/core/designsystem/component/RoomieRoomAsset.kt
Outdated
Show resolved
Hide resolved
| modifier = Modifier | ||
| .size(32.dp) | ||
| .clip(CircleShape) | ||
| .fillMaxSize() |
There was a problem hiding this comment.
clip 후에 fillMaxSize 넣어준 이유는 무엇인가요??
There was a problem hiding this comment.
image를 부모 컴포넌트에 맞게 확장하려 넣은건데 생각해보니 size를 고정해서 불필요한 코드인것 같네요 삭제하겠습니다!!
.../main/java/com/wearerommies/roomie/presentation/core/designsystem/component/RoomieKeyword.kt
Outdated
Show resolved
Hide resolved
kangyein9892
approved these changes
Jan 10, 2025
hyeeum
approved these changes
Jan 10, 2025
| } | ||
| } | ||
|
|
||
| @Composable | ||
| fun RoomieBorderKeyword( | ||
| fun RoomieOutlinedChip( |
Comment on lines
+144
to
+146
| RoomieTextWithDotChip( | ||
| firstText = "성별", | ||
| secondText = "n인실", |
There was a problem hiding this comment.
하 여기 짧아져서 너무 마음이 편안해짐 ㅋㅋㅋㅋㅋㅋㅋㅋ
There was a problem hiding this comment.
프리뷰 만들면서 이게 맞나 싶었는데 디폴트 지정하니 좋네여~!!!!
hyeeum
reviewed
Jan 10, 2025
| ) { | ||
| Text( | ||
| modifier = modifier | ||
| .width((LocalConfiguration.current.screenWidthDp * 0.106).dp) |
There was a problem hiding this comment.
엇 그런데 아래에서 패딩값을 선언해줘서 이 width는 필요없지 않나요??
There was a problem hiding this comment.
피그마에 있는거로 봐선 글자수에 상관없이 같은 width를 의도하신 것 같은데 width 지정을 안하면 width가 각자 따로 놀더라구용 그래서 지정해줬습니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏠 ISSUE
❗ WORK DESCRIPTION
📸 SCREENSHOT
💻 주요 코드
📢 TO REVIEWERS