Revive unit test project #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cp cs |
Comment on lines
-3
to
-12
| <Import Project="..\packages\MSTest.TestAdapter.1.4.0\build\net45\MSTest.TestAdapter.props" Condition="Exists('..\packages\MSTest.TestAdapter.1.4.0\build\net45\MSTest.TestAdapter.props')" /> | ||
| <PropertyGroup> | ||
| <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration> | ||
| <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform> | ||
| <ProjectGuid>{14542232-E0B6-4FDD-8B35-8F3EAE889C51}</ProjectGuid> | ||
| <OutputType>Library</OutputType> | ||
| <AppDesignerFolder>Properties</AppDesignerFolder> | ||
| <RootNamespace>STROOPUnitTests</RootNamespace> | ||
| <AssemblyName>STROOPUnitTests</AssemblyName> | ||
| <TargetFrameworkVersion>v4.6.1</TargetFrameworkVersion> |
|
same |
danebou
reviewed
Jun 11, 2024
| <RootNamespace>STROOPUnitTests</RootNamespace> | ||
| <AssemblyName>STROOPUnitTests</AssemblyName> | ||
| <TargetFramework>net462</TargetFramework> |
There was a problem hiding this comment.
The main project targets 4.6.1. Does this break anything if we switch the unit test project to that?
There was a problem hiding this comment.
I don't mind if we have to switch to v4.6.2, only reason is its just another framework to install.
There was a problem hiding this comment.
Figured it out! Would you believe this is the second time this week I've tracked down the cause of a bug as "MS decided this shouldn't work with certain TFMs anymore" with no other reason and no docs.
danebou
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched to new format as I did for the main project in #96, but all at once this time because it's relatively simple.
I had to bump the TFM to(And I learned .NET Framework tests run on Linux.)net462for one of the NuGet packages, but I don't expect that will ever be an issue.Explicitly pinned C# version at 7.1, though it could have been 7.0 but for one file. (When .NET Framework 4.6.1 released the latest would have been 6, but obviously the project adopted 7.0 soon after because tuples are used heavily.) I suggest you resolve all the existing warnings—and maybe add more Analyzers and fix their warnings too—before switching to 12 and adopting new features. Maybe you could go for 7.3 immediately, but 8 would be huge in terms of how much of the codebase you'll want to touch.