Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): prevents next step until an available commit type is selected #19

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

lincolnjpg
Copy link
Contributor

Hi,

Recently, I started using git-cc and I'm really enjoying it. I've found a behavior that I don't know if is intended.

When a invalid commit type (a commit type that is not listed in the option list) is selected, user can still advances to the next screen and then to the next. But after confirming, user returns to the initial screen.

With this PR, user can only advance to the select commit scope screen when a valid commit type was selected in the previous screen.

@SKalt
Copy link
Owner

SKalt commented Oct 21, 2022

When an invalid commit type (a commit type that is not listed in the option list) is selected, the user still advances to the next screen and then to the next. But after confirming, the user returns to the initial screen.

That's definitely undesired. I'll merge this PR now and cut a release later today.

Recently, I started using git-cc and I'm really enjoying it.

I'm glad to hear that :) Thanks for submitting a PR.

@SKalt SKalt merged commit a4dc54a into SKalt:master Oct 21, 2022
@SKalt
Copy link
Owner

SKalt commented Oct 21, 2022

I'd like to alert the user about the invalid option, too, but implementing error messages (#20) isn't a blocker for this PR.

@lincolnjpg
Copy link
Contributor Author

Thanks @SKalt and keep up the good work :)

@lincolnjpg lincolnjpg deleted the fix/only-available-commit-types branch October 21, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants