Add dynamic link signing #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcDavid155
requested changes
Feb 6, 2025
|
|
||
| X509Certificate certificate = getCertificate(session, userDocumentNumberRequest); | ||
|
|
||
| DataToSign dataToSign = SignatureBuilder.aSignature(container) |
There was a problem hiding this comment.
üpris palju on common code'i, mida annaks äkki abimeetoditeks muuta
| } | ||
|
|
||
| private X509Certificate getCertificate(HttpSession httpSession, UserDocumentNumberRequest userDocumentNumberRequest) { | ||
| smartIdV3NotificationBasedCertificateChoiceService.startCertificateChoice(httpSession, userDocumentNumberRequest); |
There was a problem hiding this comment.
siin ka, person code/document numbri puhul erinevus ainult meetodite esimeses reas, ülejäänud on neil common
| <div class="ms-3"> | ||
| <a href="#" | ||
| class="btn btn-outline-dark w-100 mb-1 signing-btn" | ||
| aria-controls="notification-signing-with-person-code">Signing with person code</a> |
There was a problem hiding this comment.
Võiks tõenäoliselt ühtlustada, et nii dynamicul kui ka notificaitonil oleks sama content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.