Improve search of trusted CA certificate in AuthenticationResponseValidator.isCertificateTrusted() #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves search of trusted CA certificate in
AuthenticationResponseValidator.isCertificateTrusted()
Adds search of trusted CA certificates by their distinguished name. Reduces overall calculations of signatures during certificate validation.
There were some problems in
AuthenticationResponseValidator.isCertificateTrusted()
:DEBUG
is turned on, then there were quite many error messages from other validations and exceptions were logged as well.Distinguished names of signer's certificate issuer and trusted CA certificate subject must be same,
because these identify the CA certificate itself,
and are signed within the CA certificate chain.
There is an assumption that CA places its subject name into the issuer field of the person's certificate,
and at least
C
,O
andCN
stay same.Also adds additional logging when trusted CA certificate is missing (#75)