-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when reloading textures #122
Comments
The crash report says you're using the beta. This version is outdated and issues for it will not be fixed. |
I updated to the latest version and it has the same issue as well as an
additional one.
…On Sun, Mar 20, 2022, 10:15 PM SHsuperCM ***@***.***> wrote:
...
citresewn: CITResewn 0.9.0+1.18.1
...
The crash report says you're using the beta. This version is outdated and
issues for it will not be fixed.
If the issue still occurs in the latest version I can reopen the issue.
—
Reply to this email directly, view it on GitHub
<#122 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUZ7N63Q2NT6KGOZRSM5XSDVA7STNANCNFSM5RGLDBSA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I'm gonna need the full logs, the issue as you described it simply does not happen to me, I've tested and reloaded during development enough(most times with editors open) and it never crashed on my end. |
Better yet, I need exact reproducible steps to cause the issue on my end in order to fix it. |
Of course. All I'm doing is f3t with a CIT pack where the folder it's in is
named Optifine, which the docs say are fine, and the textures working back
up.
Here is a crash Report (it's the same as it was with the beta version) . I
also made a clean log file by closing the game, opening it, joining a world
and loading resources.
https://paste.ee/p/yMbqH (Crash Report)
As far as I can tell the log is just the crash report in this case though.
…On Sun, Mar 20, 2022 at 10:36 PM SHsuperCM ***@***.***> wrote:
Better yet, I need exact reproducible steps to cause the issue on my end
in order to fix it.
—
Reply to this email directly, view it on GitHub
<#122 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUZ7N62EERCAVRKOGSFKGC3VA7VD5ANCNFSM5RGLDBSA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Can I also get the pack you had while reloading? I can take a look later today |
Cool thanks. Here it is the issue happened when there were only enchantment
glints in it so if it's related to the pack specifically it's probably
something with enchant glints not with the item changing.
You'll probably need to unzip it.
…On Sun, Mar 20, 2022 at 11:01 PM SHsuperCM ***@***.***> wrote:
Reopened #122 <#122>.
—
Reply to this email directly, view it on GitHub
<#122 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUZ7N66F3A5VHKMRXKGV473VA7YDFANCNFSM5RGLDBSA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
You didn't actually send the pack :p I cannot seem reproduce this, I've tried multiple combinations of things happening(including having editors open for both the enchantment image and its properties file) and it never crashed for me. |
Try getting rid of all other mods and then get the most minimal pack that causes this issue. Also a pic of your screen before the reload would help(I want to see what's in your hotbar and around the world when this happens) |
I will get you these in a moment but it seems it may not be related to
having files open. While it prevents a crash when I do it the first time,
even if I keep it closed it will crash if I reload a second time
…On Mon, Mar 21, 2022, 9:32 AM SHsuperCM ***@***.***> wrote:
Here it is
You didn't actually send the pack :p
I cannot seem reproduce this, I've tried multiple combinations of things
happening(including having editors open for both the enchantment image and
its properties file) and it never crashed for me.
—
Reply to this email directly, view it on GitHub
<#122 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUZ7N64WOGOGBM6D467JVIDVBCCBLANCNFSM5RGLDBSA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I have been running into same issue. After some experimenting, I have pinpoint that this reload crash occurs when I am using Iris Shaders, it does not crash at all with just Fabric+CIT+Sodium. The mysterious part is that it only occurred occasionally, but still frequent enough that it's very bothersome when I am tinkering with glint function. Given the logs and the nature of crash, it might have something to do with race condition when it is trying to load custom glint texture with "texture": "texture_name.png". To reproduce the issue:
Opened issue to Iris Shader repository as well. |
Just got this mod and tried it out with some basic Glint recoloring. When I reload my textures (f3t) the game will crash in a few seconds.
Doing a little bit of testing it seems to be crashing when the files that are being reloaded are also opened somewhere else on your computer, like when viewing the CIT pack in file explorer or having assets opened in Photoshop.
Here's the crash report, the item it says is being rendered in the StackTrace sometimes changes between crashes, so I don't think its relevant.
crash-2022-03-20_20.45.57-client.txt
.
The text was updated successfully, but these errors were encountered: