Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when reloading textures #122

Closed
LazyKB opened this issue Mar 21, 2022 · 11 comments
Closed

Crash when reloading textures #122

LazyKB opened this issue Mar 21, 2022 · 11 comments
Labels
bug Something isn't working stale No updates from the reporter in a while

Comments

@LazyKB
Copy link

LazyKB commented Mar 21, 2022

Just got this mod and tried it out with some basic Glint recoloring. When I reload my textures (f3t) the game will crash in a few seconds.
Doing a little bit of testing it seems to be crashing when the files that are being reloaded are also opened somewhere else on your computer, like when viewing the CIT pack in file explorer or having assets opened in Photoshop.
Here's the crash report, the item it says is being rendered in the StackTrace sometimes changes between crashes, so I don't think its relevant.
crash-2022-03-20_20.45.57-client.txt
.

@SHsuperCM SHsuperCM added the invalid This doesn't seem right label Mar 21, 2022
@SHsuperCM
Copy link
Owner

SHsuperCM commented Mar 21, 2022

...
citresewn: CITResewn 0.9.0+1.18.1
...

The crash report says you're using the beta. This version is outdated and issues for it will not be fixed.
If this still happens in the latest version I can reopen the issue.

@LazyKB
Copy link
Author

LazyKB commented Mar 21, 2022 via email

@SHsuperCM
Copy link
Owner

SHsuperCM commented Mar 21, 2022

I'm gonna need the full logs, the issue as you described it simply does not happen to me, I've tested and reloaded during development enough(most times with editors open) and it never crashed on my end.

@SHsuperCM
Copy link
Owner

Better yet, I need exact reproducible steps to cause the issue on my end in order to fix it.

@LazyKB
Copy link
Author

LazyKB commented Mar 21, 2022 via email

@SHsuperCM
Copy link
Owner

Can I also get the pack you had while reloading?

I can take a look later today

@SHsuperCM SHsuperCM reopened this Mar 21, 2022
@SHsuperCM SHsuperCM added bug Something isn't working and removed invalid This doesn't seem right labels Mar 21, 2022
@LazyKB
Copy link
Author

LazyKB commented Mar 21, 2022 via email

@SHsuperCM
Copy link
Owner

Here it is

You didn't actually send the pack :p

I cannot seem reproduce this, I've tried multiple combinations of things happening(including having editors open for both the enchantment image and its properties file) and it never crashed for me.

@SHsuperCM
Copy link
Owner

Try getting rid of all other mods and then get the most minimal pack that causes this issue. Also a pic of your screen before the reload would help(I want to see what's in your hotbar and around the world when this happens)

@LazyKB
Copy link
Author

LazyKB commented Mar 21, 2022 via email

@SHsuperCM SHsuperCM added the stale No updates from the reporter in a while label Mar 24, 2022
@chsiao58
Copy link

chsiao58 commented Jan 20, 2025

I have been running into same issue. After some experimenting, I have pinpoint that this reload crash occurs when I am using Iris Shaders, it does not crash at all with just Fabric+CIT+Sodium. The mysterious part is that it only occurred occasionally, but still frequent enough that it's very bothersome when I am tinkering with glint function. Given the logs and the nature of crash, it might have something to do with race condition when it is trying to load custom glint texture with "texture": "texture_name.png".

To reproduce the issue:

  1. Use these mods and sample resource pack.
  2. Open up game and a test world
  3. Move the sample resource pack to selected in option (Sometime the crash happens in this step)
  4. Press F3 + T to reload resource pack, this might need to be done multiple times to trigger the crash.

Opened issue to Iris Shader repository as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale No updates from the reporter in a while
Projects
None yet
Development

No branches or pull requests

3 participants