Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DAH-2876 useRedirect for authenticated pages #2488

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cade-exygy
Copy link
Collaborator

Description

If a user tries to go to the my-account, account-settings, or my-applications and is not signed in: redirect to sign in page, show banner. Once the login happens, the user is redirected to the page they were trying to access prior.

Jira ticket

https://sfgovdt.jira.com/browse/DAH-2876

Checklist before requesting review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly
  • if the changes include human translations, follow the human translations process

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

Review Instructions

  • On the review app:
  • While signed out, manually enter the restricted url: /my-account?react=true
  • It should try to load the page, but then redirect back to /sign-in
  • You should see the banner
  • Sign In to an account: [email protected] / test1234
  • Once you are signed in, you should be redirected
  • Try this with /my-account, /account-settings, and /my-applications

Test edge cases like signing out, triggering other banners, etc

@cade-exygy cade-exygy added the needs review Pull request needs review label Jan 7, 2025
@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2488 January 7, 2025 20:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Pull request needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants