Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DAH-2867 make height auto on my accounts dashboard #2475

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tallulahkay
Copy link
Contributor

@tallulahkay tallulahkay commented Dec 27, 2024

Description

Fix heights of cards in my accounts dashboard.

Jira ticket

https://sfgovdt.jira.com/browse/DAH-2867

Checklist before requesting review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly
  • if the changes include human translations, follow the human translations process

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2475 December 27, 2024 19:16 Inactive
@tallulahkay tallulahkay marked this pull request as ready for review December 27, 2024 20:22
@tallulahkay tallulahkay requested review from a team, chadbrokaw and cade-exygy and removed request for a team December 27, 2024 20:22
@tallulahkay tallulahkay added the needs review Pull request needs review label Dec 27, 2024
Copy link
Collaborator

@chadbrokaw chadbrokaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-01-02 at 9 09 58 AM I'm reviewing this and the cards look really pretty tall? Is this expected?

@tallulahkay
Copy link
Contributor Author

Screenshot 2025-01-02 at 9 09 58 AM I'm reviewing this and the cards look really pretty tall? Is this expected?

nope! lemme try to fix it!

@tallulahkay tallulahkay requested a review from chadbrokaw January 2, 2025 19:26
@tallulahkay
Copy link
Contributor Author

@chadbrokaw fixed!

@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2475 January 2, 2025 19:26 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2475 January 2, 2025 19:28 Inactive
@tallulahkay tallulahkay added needs product acceptance Pull request requires product acceptance before merging and removed needs review Pull request needs review labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs product acceptance Pull request requires product acceptance before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants