Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra vertical space between icons #170

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Extra vertical space between icons #170

merged 2 commits into from
Oct 8, 2024

Conversation

JodieM
Copy link
Contributor

@JodieM JodieM commented Aug 17, 2024

Critical Changes

None

Changes

  • Added extra vertical space between Indicator Items so when the Items wrap within the card, there is vertical space between the icons.

Issues Closed

#146

@JodieM JodieM linked an issue Aug 17, 2024 that may be closed by this pull request
The indicator icons lack vertical spacing between them #146
Closed
@JodieM JodieM requested a review from tschug August 17, 2024 11:50
tschug
tschug previously approved these changes Aug 18, 2024
View reviewed changes
Copy link
Contributor

@tschug tschug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved.

@JodieM
Copy link
Contributor Author

JodieM commented Sep 2, 2024

@tschug just one tiny change to this to make the icon spacing correct.

@tschug tschug merged commit 47245d1 into main Oct 8, 2024
2 checks passed
@tschug tschug deleted the feature/146-vertical-spacing branch October 8, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschug tschug tschug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The indicator icons lack vertical spacing between them
2 participants
@JodieM @tschug