Completed First Ruby Asg - Ming #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spragala
reviewed
Sep 13, 2017
| def generate_username (first, last, year, p_level = 0) | ||
|
|
||
| # put in variable for easy reference | ||
| new_username = format_name(first,last) + year.to_s[-2, year.to_s.length-1] |
There was a problem hiding this comment.
You have a method to format the year!
new_username = format_name(first,last) + format_year(year)
| end | ||
|
|
||
| def user_type_prefix (num) | ||
| if num == 0 |
There was a problem hiding this comment.
I'm getting some code smell - you've already written this code before. How can you refactor this code by calling the check_privilege method?
| # registered user name, if match, add '_count' to new_username, update count | ||
| # and then push into increment_name list associated with that matched user | ||
| # and then return that incremented name as output | ||
| if $users[0] == nil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
21/22
Didnt attempt the "remove special characters in strings (BONUS)" for format_name. Everything else i got it down. Probably just need some googling of doing regex