Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bryan Reese pr #21

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 78 additions & 7 deletions username.rb
Original file line number Diff line number Diff line change
@@ -1,14 +1,85 @@
# Make sure to run the tests in your /spec folder
# Run `rspec /spec/username_spec.rb` to get started.
# # Make sure to run the tests in your /spec folder
# # Run `rspec /spec/username_spec.rb` to get started.

def format_name(first, last)
nil
if first.length<1 || last.length<1
nil
else
first = first.split.join
last = last.split.join
str = (first[0]+last).downcase.gsub(/[^0-9a-z]/i, '')
end
end



#not sure why this doesnt passr
def check_privilege(type)

if type.floor == 1
"seller"

def format_year
nil
elsif type.floor == 2
"manager"

elsif type.floor == 3
"admin"

else
"user"

end
end

def build_username
nil


def user_type_prefix(type)
if type.floor == 1
"seller"+"-"

elsif type.floor == 2
"manager"+"-"

elsif type.floor == 3
"admin"+"-"

else
"user"+"-"

end
end





def format_year(year)
year.to_s.length == 4 ? year.to_s.slice(-2,2) : nil
end




def generate_username(first_name, last_name, birth_year, privilege_level)

date = birth_year.to_s.slice(-2,2)
username = (first_name[0]+last_name).downcase

if privilege_level.floor == 1
username+date

elsif privilege_level.floor == 2
username+date

elsif privilege_level.floor == 3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting some code smell - you've written the same code a couple of times. How could you refactor this to make your code more DRY?

username+date

else
username+date

end
end




16 changes: 10 additions & 6 deletions warmup.rb
Original file line number Diff line number Diff line change
@@ -1,17 +1,21 @@
# Run `rspec spec/the_warmup_spec.rb` to get started.

def say_hello
"hi"
"hello"
end

def scream(message)
message
message.upcase+"!"
end

def first_char
"z"
def first_char(word)
word[0].downcase
end

def polly_wanna
"crackercrackercracker"
def polly_wanna(word)
word*3
end

def after_you
"no, after you"
end