David's HW #18
Open
David's HW #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spragala
reviewed
Sep 13, 2017
| @@ -0,0 +1,6 @@ | |||
| <component name="InspectionProjectProfileManager"> | |||
There was a problem hiding this comment.
In your .gitignore file please include .idea/ when you're pushing your code to github.
| if last.length < 1 || first.length < 1 | ||
| nil | ||
| else | ||
| first_name = '' |
There was a problem hiding this comment.
This is cool but you're doing a lot of work here! I would think about how you could refactor this code to write it more simply.
| end | ||
|
|
||
| def format_year | ||
| nil | ||
| def user_type_prefix(level=0) |
There was a problem hiding this comment.
You're writing the same code three times here - how can you refactor this so that the code is DRY?
| end | ||
|
|
||
| def build_username | ||
| nil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.