issue- #3 - fix to spinner not going away after search #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3
in
/publify_core/app/views/admin/content/index.js.erbit seems that the spinner needs to be changed to .hide() instead of .show() after the articleList finishes renderingas far as the change in the gemfile.lock, not really sure what happened with that. I was messing with the better_erros gem and did bundle install a few times so maybe it got changed as I was changing the normal gemfile and did not go back to its original instance after I reverted my changes in the gemfile and ran bundle install.