fixed tag name error for creating new articles #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnfmnfm
suggested changes
Jan 22, 2018
| @@ -65,7 +65,7 @@ function tag_manager() { | |||
| var tagApi = jQuery("#article_keywords").tagsManager({ | |||
| prefilled: $('#article_keywords').val() | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Remove unnecessary whitespace on this line.
|
Looks good, just need to squash commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2
The "save_article_tags" method has been resolved to correctly save tags used in creating new articles/posts.
The bug of new articles containing the string "object" instead of the selected tag name was resolved by modifying file name publify_core/app/assets/javascripts/publify_admin.js to add the method for returning the value of an object, "val()", to the results of the ".find" method on line 79.
New articles now have the correct tags names shown when created.