#3 Find and hide spinner after the result gets displayed #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esthersweon
reviewed
Jan 20, 2018
| @@ -1,2 +1,2 @@ | |||
| $("#articleList").html('<%= raw escape_javascript(render(partial: "article_list", locals: { articles: @articles })) %>'); | |||
| $("#spinner").show(); | |||
| $("#spinner").hide(); | |||
There was a problem hiding this comment.
This works, but there is a more elegant solution.
There is already something in the codebase that is supposed to run after the search ajax call completes. However, it is slightly broken. I would find where that code is and fix it, instead of adding new code in a separate file.
There was a problem hiding this comment.
Actually, once you make this more elegant fix, you could get rid of this line in this file.
esthersweon
requested changes
Jan 20, 2018
| @@ -1,2 +1,2 @@ | |||
| $("#articleList").html('<%= raw escape_javascript(render(partial: "article_list", locals: { articles: @articles })) %>'); | |||
| $("#spinner").show(); | |||
| $("#spinner").hide(); | |||
There was a problem hiding this comment.
Actually, once you make this more elegant fix, you could get rid of this line in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3 Find and hide spinner
Explanation: