issue #2 - save_article_tags function was not referencing string value #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnfmnfm
suggested changes
Jan 20, 2018
| @@ -76,7 +76,7 @@ function tag_manager() { | |||
| } | |||
|
|
|||
| function save_article_tags() { | |||
| $('#article_keywords').val($('#article_form').find('input[name="hidden-article[keywords]"]')); | |||
| $('#article_keywords').val($('#article_form').find('input[name="hidden-article[keywords]"]')["0"].defaultValue); | |||
There was a problem hiding this comment.
This seems dangerous for two reasons:
(1) Why are you indexing into an array using a string?
(2) Why are you using the default value from that input field, rather than the actual value that a user has typed in?
…string value for the tag
kjkeaston
force-pushed
the
2-post_tags
branch
from
4b88f6c to
120c056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2
save_article_tags function in
publify_admin.jswas not referencing the string value for the tag correctly and instead was pulling a large object