Post tags correctly #2 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esthersweon
reviewed
Jan 20, 2018
| <h3 class="sidebar_title"><%= sidebar.title %></h3> | ||
| <div class="sidebar_body"> | ||
| <h3 class="sidebar-title"><%= sidebar.title %></h3> | ||
| <div class="sidebar-body"> |
esthersweon
reviewed
Jan 20, 2018
| @@ -77,6 +77,7 @@ function tag_manager() { | |||
|
|
|||
| function save_article_tags() { | |||
| $('#article_keywords').val($('#article_form').find('input[name="hidden-article[keywords]"]')[0].value); | |||
|
|
|||
|
I would create a new branch off |
esthersweon
reviewed
Jan 20, 2018
| @@ -76,7 +76,8 @@ function tag_manager() { | |||
| } | |||
|
|
|||
| function save_article_tags() { | |||
| $('#article_keywords').val($('#article_form').find('input[name="hidden-article[keywords]"]')); | |||
| $('#article_keywords').val($('#article_form').find('input[name="hidden-article[keywords]"]')[0].value); | |||
There was a problem hiding this comment.
You could also just add jQuery method .val()
|
Still has the same issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
On publish button click, the method "save_article_tags" gets called which saves the tag in db. So identified that the problematic area is here. In console, inspected that input tag element and noted that ("[0].value") was missing at the end to fetch the actual tags value in the input tag.
I added new tags and it gets displayed successfully.