problem 1. corrected sidebar fonts to monospace. Changed bullets to u… #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esthersweon
reviewed
Jan 19, 2018
| @@ -1,5 +1,5 @@ | |||
| <% unless sidebar.authors.blank? %> | |||
| <h3 class="sidebar-title"><%= t(".authors")%></h3> | |||
| <h3 class="sidebar_title"><%= t(".authors")%></h3> | |||
There was a problem hiding this comment.
this was an accident in debugging. i should change it back
esthersweon
reviewed
Jan 19, 2018
| @@ -22,7 +22,7 @@ | |||
| padding: 45px; | |||
| border: 1px solid #ccc; | |||
| } | |||
| .sidebar_item { | |||
| .sidebar-item { | |||
There was a problem hiding this comment.
I changed this because this controlled the font styling for the Archive sidebar. I could've left this css file alone and only changed the class on the HTML file. Now I know it is an unnecessary change.
There was a problem hiding this comment.
Yes, sidebar-item is not a class used anywhere.
Please push changes addressing my comments to this same branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes the sidebar font & bullets inconsistency issues.
All sidebars now in monospace font. All bullets now unfilled circles
#1
Sidebar fonts:
Located the correct class that controls the font for the “tags” sidebar with a global search.
It was in bootstrap-2/stylesheets.style.css. the class is called “.sidebar-title”
Located the html file with class that controls the in-correct font for the “archive” sidebar.
It was in lib/author_sidebar/app/views/archive_sidebar/_content.html.erb.
I changed the “.sidebar_title” into “.sidebar-title.”
Located the css file with class that controls the in-correct font for the “archive” sidebar.
It was in sidebar_admin.css.scss
changed the “.sidebar_title” into “.sidebar-title.”
Sidebar bullets: