Correct inclusion of parentheses when outputing constraints #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pebenito
requested changes
May 6, 2024
setools/policyrep/constraint.pxi
Outdated
Comment on lines
201
to
204
| class StackObj: | ||
| def __init__(self, precedence, expression): | ||
| self.precedence = precedence | ||
| self.expression = expression |
pebenito
approved these changes
May 6, 2024
|
Please squash to 1 commit, then I'll merge. |
Signed-off-by: Marshall Miller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing algorithm to convert constraints from postfix to infix notation does not insert parentheses correctly. This change addresses the problem.
For example, given the following expression in the source policy:
( t2 == ssh_client_packet_t or t2 == ssh_server_packet_t ) and t1 == sshd_t
The output currently returned would be:
t2 == ssh_client_packet_t or ( t2 == ssh_server_packet_t ) and ( t1 == sshd_t )
Which of course is not equivalent to the actual expression due to the lack of parentheses surrounding the "or" expression.