Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readhandler): Avoid reading the same node multiple times #89

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

jrtitus
Copy link
Collaborator

@jrtitus jrtitus commented Oct 16, 2024

The incorrect index was being used when populating the responses slice.

Thank you @syoliver for this fix.

PR Checklist

If your build fails due to your commit message not passing the build checks, please review the guidelines here.

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

See unit tests

New Dependency Instructions (If applicable)

@jrtitus jrtitus merged commit 2767746 into main Oct 16, 2024
2 checks passed
@jrtitus jrtitus deleted the fix/read-single-node-multiple-times branch October 16, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants