Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(readhandler): Group multiple nodes into a single request #88

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

jrtitus
Copy link
Collaborator

@jrtitus jrtitus commented Oct 10, 2024

Improves read performance by grouping resources in commands into a single OPC UA request.

Special thanks to @syoliver for providing a majority of the necessary modifications.

PR Checklist

If your build fails due to your commit message not passing the build checks, please review the guidelines here.

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

  • Run EdgeX Foundry and device-opcua service as normal

New Dependency Instructions (If applicable)

N/A

Special thanks to @syoliver for providing a majority of the required modifications
@jrtitus jrtitus requested a review from nyameen October 10, 2024 18:53
Copy link

@nyameen nyameen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Minor change, not totally required.

@jrtitus jrtitus merged commit 0e318a2 into main Oct 11, 2024
2 checks passed
@jrtitus jrtitus deleted the refactor/request-grouping branch October 11, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants