Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize ma::Input::debugFolder and default to working directory #402

Merged
merged 2 commits into from
Nov 12, 2023
Merged

Initialize ma::Input::debugFolder and default to working directory #402

merged 2 commits into from
Nov 12, 2023

Conversation

bobpaw
Copy link
Collaborator

@bobpaw bobpaw commented Nov 11, 2023

Initialize ma::Input::debugFolder and default to working directory

  • Update setDefaultValues().
  • Check for debugFolder in verbose ma::adaptVerbose.
  • This fixes a segfault when calling ma::adaptVerbose(in, true) without setting in->debugFolder first.
  • Previously, not explicitly setting debugFolder was undefined behavior
  • Now, when debugFolder is not set, debug mesh VTKs are placed in the working directory.

@bobpaw
Initialize ma::Input::debugFolder and default to working directory
fb19d90 
Update setDefaultValues().
Check for debugFolder in verbose ma::adaptVerbose.
This fixes a segfault when calling ma::adaptVerbose(in, true) without setting
in->debugFolder first.

Signed-off-by: Aiden Woodruff <[email protected]>
cwsmith
cwsmith requested changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@cwsmith cwsmith left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. It looks like on line 207 in dumpMeshWithFlag(...) the same logic appears. Would you please fix that one too?

@cwsmith cwsmith added the bug label Nov 12, 2023
@bobpaw
Copy link
Collaborator Author

bobpaw commented Nov 12, 2023

@cwsmith, I updated that line too.

@bobpaw bobpaw requested a review from cwsmith November 12, 2023 02:06
cwsmith
cwsmith approved these changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cwsmith cwsmith merged commit e77640c into develop Nov 12, 2023
4 checks passed
@cwsmith cwsmith deleted the apw/init_debugfolder branch November 12, 2023 02:16
@bobpaw bobpaw added the v2.2.9 label Nov 30, 2023
@cwsmith cwsmith mentioned this pull request Oct 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwsmith cwsmith cwsmith approved these changes

Assignees
No one assigned
Labels
bug v2.2.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobpaw @cwsmith