Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MeshCAP implementation of Mesh2 to interface with Capstone #400
Add MeshCAP implementation of Mesh2 to interface with Capstone #400
Changes from all commits
29c4a49
fc9304d
17d290b
68aea15
d40df73
46461ab
cd90e47
096f72b
ed74a33
1a54855
ba02a7d
893c13f
7daa993
b21621b
29e1518
86c94f2
96c329e
b582525
d0ff10e
9c31d65
923a45c
662fa8e
cf65617
b7760ec
f779676
6cd320a
5c45b67
8e65151
6bbe67e
db7829f
5456357
59a8bd5
f511fab
ef6ff7d
77e751a
7488d5a
0debe26
47a267d
5def445
43d7ede
d4f8154
a47467f
6357402
162b03e
4549293
0c66720
e920208
a1b9664
949fe75
82ae8f7
ccc455d
9336031
d5bc112
1b65c7c
a2211b1
c60a940
34dfd8c
2a7b17d
d9e72dd
7a84c0f
6c55fb4
480c2ba
6015c44
bbd2297
0df14fc
ded0081
ca352f4
fe19512
91eb068
830fc09
c53a3a7
6f5ca02
f192d63
2f15801
3d19bde
9e47f8d
b11e676
013b0f6
24ca632
c96ace6
56ef29c
9f67b80
0b82c02
1136bed
6d22bdc
7e73ef6
4ff21fb
ce1140a
489b050
2c8e18b
e6aa482
9a3037d
06d7c7c
4ea21b4
9b1bf76
8b52606
5a48535
6801aba
453362b
81bcc36
609e1ac
40ebce9
ba627b8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, these changes are modifying the canonical ordering of entities. If that is correct, will enabling Capstone break support for Simmetrix meshes? If we haven't tested that combination, would you please try building with
-DENABLE_SIMMETRIX=on
and-DENABLE_CAPSTONE=on
then runningctest
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failures with Simmetrix (mpich3) (no change with nocxx11abi)
The following tests FAILED:
96 - parallel_meshgen (Failed)
97 - parallel_meshgen_surf (Failed)
98 - parallel_meshgen_vol (Failed)
Failures with Capstone
The following tests FAILED:
5 - bezierElevation (Failed)
6 - bezierMesh (Failed)
8 - bezierRefine (Failed)
9 - bezierSubdivision (Failed)
10 - bezierValidity (Failed)
75 - nedelec (Failed)
78 - h1_shape_serial (Failed)
79 - h1_shape_parallel (Failed)
Failures with Capstone and Simmetrix
The following tests FAILED:
5 - bezierElevation (Failed)
6 - bezierMesh (Failed)
8 - bezierRefine (Failed)
9 - bezierSubdivision (Failed)
10 - bezierValidity (Failed)
80 - nedelec (Failed)
83 - h1_shape_serial (Failed)
84 - h1_shape_parallel (Failed)
96 - parallel_meshgen (Failed)
97 - parallel_meshgen_surf (Failed)
98 - parallel_meshgen_vol (Failed)
My interpretation is that the combination of the two causes no extra breakage. However, the capstone failures merit investigation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for testing. I have seen the
parallel_meshgen_*
on the rhel9 systems (#398); as you said, they are unrelated to this PR. Ideally, we can quickly resolve the capstone test failures but I won't be opposed to merging this and creating another PR to fix the errors if time is tight/limited.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why Morteza added this change (in commit 5def445). I need to make Capstone test meshes with tets because right now all new capstone tests pass when this section is reverted. Reverting just this section fixes bezierElevation, bezierSubdivision, nedelec, and h1_shape_*. However, it doesn't fix bezierMesh or bezierValidity which is beguiling. Is there capstone documentation that would back up the tet-reorder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so I've checked out the capstone mesh topologies and these are the correct values. Not sure if this will create incompatibilities.