Skip to content

Commit

Permalink
Merge pull request #80 from SCIInstitute/build_warnings
Browse files Browse the repository at this point in the history
Cleaver include warnings fixed
  • Loading branch information
allywarner authored May 23, 2019
2 parents b98fccc + c0e71a1 commit 99ab41c
Show file tree
Hide file tree
Showing 30 changed files with 71 additions and 74 deletions.
6 changes: 3 additions & 3 deletions src/examples/implicit_spheres.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
#include <cstring>
#include <cstdlib>

#include <Cleaver/Cleaver.h>
#include <Cleaver/InverseField.h>
#include <Cleaver/Volume.h>
#include <cleaver/Cleaver.h>
#include <cleaver/InverseField.h>
#include <cleaver/Volume.h>

class MockupField : public cleaver::AbstractScalarField
{
Expand Down
12 changes: 6 additions & 6 deletions src/examples/test_data.cpp
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
#include <Cleaver/Cleaver.h>
#include <Cleaver/InverseField.h>
#include <Cleaver/ConstantField.h>
#include <Cleaver/vec3.h>
#include <Cleaver/AbstractScalarField.h>
#include <Cleaver/BoundingBox.h>
#include <cleaver/Cleaver.h>
#include <cleaver/InverseField.h>
#include <cleaver/ConstantField.h>
#include <cleaver/vec3.h>
#include <cleaver/AbstractScalarField.h>
#include <cleaver/BoundingBox.h>

#include <Synthetic/PlaneField.h>
#include <Synthetic/PlaneSizingField.h>
Expand Down
6 changes: 3 additions & 3 deletions src/gui/Application/Data/DataManager.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include "DataManager.h"
#include <QMessageBox>
#include <Cleaver/InverseField.h>
#include <Cleaver/AbstractScalarField.h>
#include <cleaver/InverseField.h>
#include <cleaver/AbstractScalarField.h>

DataManager::DataManager() : mesh_(nullptr), sizingField_(nullptr), volume_(nullptr) {}

Expand Down Expand Up @@ -33,4 +33,4 @@ std::vector<cleaver::AbstractScalarField* > DataManager::indicators() const { re

cleaver::Volume* DataManager::volume() const { return this->volume_; }

cleaver::TetMesh* DataManager::mesh() const { return this->mesh_; }
cleaver::TetMesh* DataManager::mesh() const { return this->mesh_; }
4 changes: 2 additions & 2 deletions src/gui/Application/Data/DataManager.h
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#ifndef DATAMANAGER_H
#define DATAMANAGER_H

#include <Cleaver/TetMesh.h>
#include <Cleaver/Volume.h>
#include <cleaver/TetMesh.h>
#include <cleaver/Volume.h>
#include <QObject>
#include <stdlib.h>

Expand Down
6 changes: 3 additions & 3 deletions src/gui/Application/DataWidgets/DataManagerWidget.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
#include "VolumeDataWidget.h"
#include <map>
#include <string>
#include <Cleaver/ScalarField.h>
#include <Cleaver/Volume.h>
#include <Cleaver/TetMesh.h>
#include <cleaver/ScalarField.h>
#include <cleaver/Volume.h>
#include <cleaver/TetMesh.h>
#include <Data/DataManager.h>

namespace Ui {
Expand Down
4 changes: 2 additions & 2 deletions src/gui/Application/DataWidgets/FieldDataWidget.cpp
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#include "FieldDataWidget.h"
#include "ui_FieldDataWidget.h"
#include <sstream>
#include <Cleaver/ScalarField.h>
#include <Cleaver/BoundingBox.h>
#include <cleaver/ScalarField.h>
#include <cleaver/BoundingBox.h>
#include <NRRDTools.h>
#include <QMouseEvent>
#include <QMenu>
Expand Down
6 changes: 3 additions & 3 deletions src/gui/Application/DataWidgets/FieldDataWidget.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

#include <QWidget>
#include <QStyle>
#include <Cleaver/ScalarField.h>
#include <cleaver/ScalarField.h>

namespace Ui {
class FieldDataWidget;
Expand All @@ -12,12 +12,12 @@ class FieldDataWidget;
class FieldDataWidget : public QWidget
{
Q_OBJECT

public:
explicit FieldDataWidget(QWidget *parent = 0);
FieldDataWidget(cleaver::AbstractScalarField *field, QWidget *parent = 0);
~FieldDataWidget();

void setTitle(const std::string &title);
signals:
void exportField(void*);
Expand Down
4 changes: 2 additions & 2 deletions src/gui/Application/DataWidgets/MeshDataWidget.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

#include <QFrame>
#include <string>
#include <Cleaver/TetMesh.h>
#include <cleaver/TetMesh.h>

namespace Ui {
class MeshDataWidget;
Expand All @@ -12,7 +12,7 @@ class MeshDataWidget;
class MeshDataWidget : public QWidget
{
Q_OBJECT

public:
explicit MeshDataWidget(QWidget *parent = 0);
MeshDataWidget(cleaver::TetMesh *mesh, QWidget *parent = 0);
Expand Down
6 changes: 3 additions & 3 deletions src/gui/Application/DataWidgets/MiniFieldWidget.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#define MINIFIELDWIDGET_H

#include <QWidget>
#include <Cleaver/ScalarField.h>
#include <cleaver/ScalarField.h>

namespace Ui {
class MiniFieldWidget;
Expand All @@ -11,7 +11,7 @@ class MiniFieldWidget;
class MiniFieldWidget : public QWidget
{
Q_OBJECT

public:
explicit MiniFieldWidget(QWidget *parent = 0);
MiniFieldWidget(cleaver::AbstractScalarField *field, QWidget *parent = 0);
Expand Down Expand Up @@ -39,7 +39,7 @@ class MiniFieldWidget : public QWidget
void dragLeaveEvent(QDragLeaveEvent *event);
void dropEvent(QDropEvent *event);


private:
Ui::MiniFieldWidget *ui;
cleaver::AbstractScalarField *m_field;
Expand Down
2 changes: 1 addition & 1 deletion src/gui/Application/DataWidgets/VolumeDataWidget.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

#include <QWidget>
#include <QStyle>
#include <Cleaver/Volume.h>
#include <cleaver/Volume.h>
#include "MiniFieldWidget.h"
#include <map>

Expand Down
8 changes: 4 additions & 4 deletions src/gui/Application/MainWindow.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include "MainWindow.h"
#include <Cleaver/Cleaver.h>
#include <Cleaver/ConstantField.h>
#include <Cleaver/InverseField.h>
#include <cleaver/Cleaver.h>
#include <cleaver/ConstantField.h>
#include <cleaver/InverseField.h>
#include <cstdio>
#include <fstream>
#include <QProgressDialog>
Expand All @@ -12,7 +12,7 @@
#include <QStatusBar>
#include <QLayoutItem>
#include <QLabel>
#include <Cleaver/ScalarField.h>
#include <cleaver/ScalarField.h>

MainWindow::MainWindow(QWidget *parent) :
QMainWindow(parent) {}
Expand Down
8 changes: 4 additions & 4 deletions src/gui/Application/MainWindow.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
#include "ToolWidgets/CleaverWidget.h"
#include "ToolWidgets/SizingFieldWidget.h"
#include "DataWidgets/DataManagerWidget.h"
#include <Cleaver/Cleaver.h>
#include <Cleaver/CleaverMesher.h>
#include <cleaver/Cleaver.h>
#include <cleaver/CleaverMesher.h>
#include "Data/DataManager.h"
#include <QProgressBar>

Expand Down Expand Up @@ -88,7 +88,7 @@ public slots :
// Compute Menu Action
QAction *computeAnglesAct;

// Tool Menu Actions
// Tool Menu Actions
QAction *cleaverAction;
QAction *meshViewOptionsAction;
QAction *sizingFieldAction;
Expand All @@ -105,7 +105,7 @@ public slots :
QMenu *m_computeMenu;
QMenu *m_viewMenu;
QMenu *m_helpMenu;

//status bar items
QProgressBar * progressBar_;

Expand Down
8 changes: 4 additions & 4 deletions src/gui/Application/ToolWidgets/CleaverWidget.cpp
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
#include "CleaverWidget.h"
#include "ui_CleaverWidget.h"
#include <Cleaver/TetMesh.h>
#include <Cleaver/Cleaver.h>
#include <Cleaver/Timer.h>
#include <Cleaver/SizingFieldCreator.h>
#include <cleaver/TetMesh.h>
#include <cleaver/Cleaver.h>
#include <cleaver/Timer.h>
#include <cleaver/SizingFieldCreator.h>
#include <iostream>
#include <QApplication>
#include <stdexcept>
Expand Down
4 changes: 2 additions & 2 deletions src/gui/Application/ToolWidgets/CleaverWidget.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#define CLEAVERWIDGET_H

#include <QDockWidget>
#include <Cleaver/CleaverMesher.h>
#include <cleaver/CleaverMesher.h>
#include <QThread>

Q_DECLARE_METATYPE(std::string)
Expand Down Expand Up @@ -56,7 +56,7 @@ public slots:
void handleMessage(std::string);
void handleProgress(int);
void handleErrorMessage(std::string);

private:
Ui::CleaverWidget *ui;
cleaver::CleaverMesher& mesher_;
Expand Down
10 changes: 5 additions & 5 deletions src/gui/Application/ToolWidgets/SizingFieldWidget.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@
#include <iostream>
#include <string>
#include <vector>
#include <Cleaver/Cleaver.h>
#include <Cleaver/ConstantField.h>
#include <Cleaver/InverseField.h>
#include <Cleaver/ScaledField.h>
#include <Cleaver/SizingFieldCreator.h>
#include <cleaver/Cleaver.h>
#include <cleaver/ConstantField.h>
#include <cleaver/InverseField.h>
#include <cleaver/ScaledField.h>
#include <cleaver/SizingFieldCreator.h>
#include <NRRDTools.h>
#include <stdexcept>

Expand Down
2 changes: 1 addition & 1 deletion src/gui/Application/ToolWidgets/SizingFieldWidget.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#define DATALOADERWIDGET_H

#include <QDockWidget>
#include <Cleaver/CleaverMesher.h>
#include <cleaver/CleaverMesher.h>
#include <QThread>

namespace Ui {
Expand Down
2 changes: 1 addition & 1 deletion src/gui/Application/ViewWidgets/Camera.h
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#ifndef CAMERA_H
#define CAMERA_H

#include <Cleaver/vec3.h>
#include <cleaver/vec3.h>

class Camera
{
Expand Down
2 changes: 1 addition & 1 deletion src/gui/Application/ViewWidgets/MeshViewOptionsWidget.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#include <QSignalMapper>
#include <QStandardItemModel>
#include "MeshWindow.h"
#include <Cleaver/CleaverMesher.h>
#include <cleaver/CleaverMesher.h>

class CheckableItemModel : public QStandardItemModel
{
Expand Down
6 changes: 3 additions & 3 deletions src/gui/Application/ViewWidgets/MeshWindow.cpp
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#include "MeshWindow.h"
#include "TrackballCamera.h"
#include <Cleaver/BoundingBox.h>
#include <Cleaver/vec3.h>
#include <Cleaver/Vertex.h>
#include <cleaver/BoundingBox.h>
#include <cleaver/vec3.h>
#include <cleaver/Vertex.h>
#include "../../lib/cleaver/Plane.h"
#include <QMouseEvent>
#include <QFileDialog>
Expand Down
6 changes: 3 additions & 3 deletions src/gui/Application/ViewWidgets/MeshWindow.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
#include <QOpenGLShaderProgram>
#include <QOpenGLBuffer>
#include <QOpenGLVertexArrayObject>
#include <Cleaver/CleaverMesher.h>
#include <Cleaver/TetMesh.h>
#include <Cleaver/Volume.h>
#include <cleaver/CleaverMesher.h>
#include <cleaver/TetMesh.h>
#include <cleaver/Volume.h>
#include "Camera.h"
#include <QMatrix4x4>

Expand Down
4 changes: 2 additions & 2 deletions src/gui/Application/ViewWidgets/TargetCamera.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
#define TARGETCAMERA_H

#include "Camera.h"
#include <Cleaver/vec3.h>
#include <Cleaver/BoundingBox.h>
#include <cleaver/vec3.h>
#include <cleaver/BoundingBox.h>

class TargetCamera : public Camera
{
Expand Down
2 changes: 1 addition & 1 deletion src/gui/Application/ViewWidgets/TrackballCamera.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#include "TrackballCamera.h"
#include <Cleaver/vec3.h>
#include <cleaver/vec3.h>
#include <cmath>
#include <QMatrix4x4>

Expand Down
4 changes: 2 additions & 2 deletions src/gui/Application/ViewWidgets/TrackballCamera.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
#include "Camera.h"
#include <QQuaternion>
#include <QVector2D>
#include <Cleaver/vec3.h>
#include <Cleaver/BoundingBox.h>
#include <cleaver/vec3.h>
#include <cleaver/BoundingBox.h>

class TrackballCamera : public Camera
{
Expand Down
4 changes: 1 addition & 3 deletions src/gui/Main/main.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include <QApplication>
#include <QtGui>
#include "MainWindow.h"
#include <Cleaver/Cleaver.h>
#include <cleaver/Cleaver.h>

int main(int argc, char *argv[])
{
Expand All @@ -14,5 +14,3 @@ int main(int argc, char *argv[])
w.show();
return a.exec();
}


4 changes: 2 additions & 2 deletions src/lib/synthetic/PlaneField.h
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#ifndef PLANEFIELD_H
#define PLANEFIELD_H

#include <Cleaver/ScalarField.h>
#include <Cleaver/BoundingBox.h>
#include <cleaver/ScalarField.h>
#include <cleaver/BoundingBox.h>


class PlaneField : public cleaver::FloatField
Expand Down
2 changes: 1 addition & 1 deletion src/lib/synthetic/PlaneSizingField.h
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#ifndef PLANESIZINGFIELD_H
#define PLANESIZINGFIELD_H

#include <Cleaver/ScalarField.h>
#include <cleaver/ScalarField.h>
#include "PlaneField.h"

class PlaneSizingField : public cleaver::FloatField
Expand Down
4 changes: 2 additions & 2 deletions src/lib/synthetic/SphereField.h
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#ifndef SPHEREFIELD_H
#define SPHEREFIELD_H

#include <Cleaver/ScalarField.h>
#include <Cleaver/BoundingBox.h>
#include <cleaver/ScalarField.h>
#include <cleaver/BoundingBox.h>

class SphereSizingField;

Expand Down
3 changes: 1 addition & 2 deletions src/lib/synthetic/SphereSizingField.h
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#ifndef SPHERESIZINGFIELD_H
#define SPHERESIZINGFIELD_H

#include <Cleaver/ScalarField.h>
#include <cleaver/ScalarField.h>
#include "SphereField.h"

class SphereSizingField : public cleaver::FloatField
Expand All @@ -19,4 +19,3 @@ class SphereSizingField : public cleaver::FloatField
};

#endif // SPHERESIZINGFIELD_H

Loading

0 comments on commit 99ab41c

Please sign in to comment.