-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3036 point name in point properties page has a limited visible length #3053
Merged
Limraj
merged 4 commits into
release/2.8.0
from
feature/#3036_point_name_in_point_properties_page_has_a_limited_visible_length
Nov 27, 2024
Merged
#3036 point name in point properties page has a limited visible length #3053
Limraj
merged 4 commits into
release/2.8.0
from
feature/#3036_point_name_in_point_properties_page_has_a_limited_visible_length
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added style parameter to point name in point properties view
Limraj
reviewed
Nov 25, 2024
@@ -49,7 +49,7 @@ | |||
<spring:bind path="form.name"> | |||
<tr> | |||
<td class="formLabelRequired"><spring:message code="pointEdit.props.name"/></td> | |||
<td class="formField"><input type="text" name="name" value="${status.value}"/></td> | |||
<td class="formField" style="width: 98%;"><input type="text" name="name" value="${status.value}" style="width: 98%;"/></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest using the formLong css class that is used in the description field, and use c:out :
<td class="formField"><input type="text"
class="formLong" name="name" value="<c:out value="${status.value}"/>"/></td>
- Created css class formLongFieldSizing; - Added attribute title and css class formLongFieldSizing in pointProperties.jsp for name fields; - Set width 60%/40% in dataPointEdit.jsp; - Use c:out in pointProperties.jsp for name and description fields;
- Set max-width is 650px
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added style parameter to point name in point properties view