Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3036 point name in point properties page has a limited visible length #3053

Conversation

Patrykb0802
Copy link
Contributor

Added style parameter to point name in point properties view

Added style parameter to point name in point properties view
Copy link

github-actions bot commented Nov 20, 2024

Java Script Mocha Unit Test Results

268 tests  ±0   268 ✅ ±0   3s ⏱️ ±0s
 70 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 696441c. ± Comparison against base commit c95948e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 20, 2024

Java JUnit Test Results

2 517 tests  ±0   2 517 ✅ ±0   47s ⏱️ +3s
  116 suites ±0       0 💤 ±0 
  116 files   ±0       0 ❌ ±0 

Results for commit 696441c. ± Comparison against base commit c95948e.

♻️ This comment has been updated with latest results.

@Limraj Limraj modified the milestones: 2.9.0, 2.7.8, 2.8.0 Nov 21, 2024
@@ -49,7 +49,7 @@
<spring:bind path="form.name">
<tr>
<td class="formLabelRequired"><spring:message code="pointEdit.props.name"/></td>
<td class="formField"><input type="text" name="name" value="${status.value}"/></td>
<td class="formField" style="width: 98%;"><input type="text" name="name" value="${status.value}" style="width: 98%;"/></td>
Copy link
Collaborator

@Limraj Limraj Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using the formLong css class that is used in the description field, and use c:out :

<td class="formField"><input type="text" class="formLong" name="name" value="<c:out value="${status.value}"/>"/></td>

Patrykb0802 and others added 3 commits November 25, 2024 18:50
- Created css class formLongFieldSizing;
- Added attribute title and css class formLongFieldSizing in pointProperties.jsp for name fields;
- Set width 60%/40% in dataPointEdit.jsp;
- Use c:out in pointProperties.jsp for name and description fields;
@Limraj Limraj merged commit 358f13c into release/2.8.0 Nov 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants