Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: warn when scoping suffix is set too late #10781

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Feb 5, 2025

To address wrong use of scoping, which happens more often recently, we log a warning when scoping is set after any tag definition. Because for scoping to work, it must be set and known before custom elements definitions.

Fixes: #10771

@ilhan007 ilhan007 requested a review from pskelin February 5, 2025 17:02
@ilhan007 ilhan007 requested a review from vladitasev February 6, 2025 14:54
@ilhan007 ilhan007 merged commit dffec17 into main Feb 6, 2025
12 checks passed
@ilhan007 ilhan007 deleted the chore-scoping-warning branch February 6, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[framework]: add console warning when setting scoping suffix if components are already defined
2 participants