Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(TableRowActionBase): the actions slot is set automatically #10766

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(TableRowActionBase): the actions slot is set automatically #10766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/main/src/TableRowActionBase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ abstract class TableRowActionBase extends UI5Element {
}

onEnterDOM(): void {
this.setAttribute("slot", "actions");
this.toggleAttribute("_fixed", this.isFixedAction());
}

Expand Down
24 changes: 12 additions & 12 deletions packages/main/test/pages/TableRowActions.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,39 +32,39 @@
<ui5-table-cell><ui5-label>30 x 18 x 3 cm</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label style="color: #648564"><b>4.2</b> KG</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label><b>399.99</b> EUR</ui5-label></ui5-table-cell>
<ui5-table-row-action-navigation slot="actions"></ui5-table-row-action-navigation>
<ui5-table-row-action-navigation></ui5-table-row-action-navigation>
</ui5-table-row>
<ui5-table-row row-key="2" interactive>
<ui5-table-cell><ui5-label><b>Notebook Basic 15</b><br><a href="#">HT-1000</a></ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label>Very Best Screens</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label>30 x 18 x 3 cm</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label style="color: #2b7c2b"><b>4.2</b> KG</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label><b>399.99</b> EUR</ui5-label></ui5-table-cell>
<ui5-table-row-action slot="actions" icon="delete" text="Delete"></ui5-table-row-action>
<ui5-table-row-action slot="actions" icon="add" text="Add"></ui5-table-row-action>
<ui5-table-row-action slot="actions" icon="disconnected" text="Disconnect"></ui5-table-row-action>
<ui5-table-row-action slot="actions" icon="share" text="Share"></ui5-table-row-action>
<ui5-table-row-action slot="actions" icon="heart" text="TestAction2"></ui5-table-row-action>
<ui5-table-row-action-navigation slot="actions" interactive></ui5-table-row-action-navigation>
<ui5-table-row-action icon="delete" text="Delete"></ui5-table-row-action>
<ui5-table-row-action icon="add" text="Add"></ui5-table-row-action>
<ui5-table-row-action icon="disconnected" text="Disconnect"></ui5-table-row-action>
<ui5-table-row-action icon="share" text="Share"></ui5-table-row-action>
<ui5-table-row-action icon="heart" text="TestAction2"></ui5-table-row-action>
<ui5-table-row-action-navigation interactive></ui5-table-row-action-navigation>
</ui5-table-row>
<ui5-table-row row-key="3" navigated>
<ui5-table-cell><ui5-label><b>Notebook Basic 15</b><br><a href="#">HT-1000</a></ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label>Very Best Screens</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label>30 x 18 x 3 cm</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label style="color: #2b7c2b"><b>4.2</b> KG</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label><b>399.99</b> EUR</ui5-label></ui5-table-cell>
<ui5-table-row-action slot="actions" icon="database" text="Delete" disabled></ui5-table-row-action>
<ui5-table-row-action slot="actions" icon="disconnected" invisible text="Disconnect"></ui5-table-row-action>
<ui5-table-row-action slot="actions" icon="detail-more" text="TestAction1"></ui5-table-row-action>
<ui5-table-row-action icon="database" text="Delete" disabled></ui5-table-row-action>
<ui5-table-row-action icon="disconnected" invisible text="Disconnect"></ui5-table-row-action>
<ui5-table-row-action icon="detail-more" text="TestAction1"></ui5-table-row-action>
</ui5-table-row>
<ui5-table-row row-key="4">
<ui5-table-cell><ui5-label><b>Notebook Basic 15</b><br><a href="#">HT-1000</a></ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label>Very Best Screens</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label>30 x 18 x 3 cm</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label style="color: #2b7c2b"><b>4.2</b> KG</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label><b>399.99</b> EUR</ui5-label></ui5-table-cell>
<ui5-table-row-action slot="actions" icon="database" text="Database"></ui5-table-row-action>
<ui5-table-row-action slot="actions" icon="add" text="Add"></ui5-table-row-action>
<ui5-table-row-action icon="database" text="Database"></ui5-table-row-action>
<ui5-table-row-action icon="add" text="Add"></ui5-table-row-action>
</ui5-table-row>
</ui5-table>

Expand Down