-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-link): introduce reactive area size property #10762
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
As far as I've checked, the explanatory texts are absolutely identical to the corresponding ones in [FEATURE] sap.m.Link: Reactive area size API introduced. The commit header description follows correctly the convention.
Officially, this feature seems to be called Target Size rather than Reactive Area Size: In our internal Wiki it's also called Target Size, but there are a few mentions of "reactive area size". Additionally, the values I would personally understand more naturally something like:
Let's discuss |
We settled on |
Regarding the second note: It is recommended to use the |
Hello, please consider a tentative suggestion for the second's note text, This is based on the Vladi's suggestion: It is recommended to use the Setting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
A new enumeration property called "interactiveAreaSize" is now added.
It is designed to make links easier to activate and helps meet the WCAG 2.2 Target Size requirement.
The property is applicable only for the SAP Horizon themes.
The interactive area should be sufficiently large to help users avoid accidentally selecting (clicking or tapping) on unintended UI elements.
There are two possible values for this property:
Normal
andLarge
:Normal
and it implies no change in the visualization and behavior of the interactive elements.Large
. In this case the height of the interactive target area is increased. This option should be used when the interactive element is displayed as an overlay on top of other interactive parts of the page.