fix(ui5-calendar): using the correct parameter for UTC when formatting a date #10713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Todor-ads small remark, the convention for cmt msg is: |
Todor-ads
changed the title
tsanislavgatev
requested changes
Jan 30, 2025
packages/main/src/Calendar.ts
Outdated
| @@ -572,7 +572,7 @@ class Calendar extends CalendarPart { | |||
| const secondYearFormat = DateFormat.getDateInstance({ format: "y", calendarType: this._secondaryCalendarType }); | |||
| const dateInSecType = transformDateToSecondaryType(this._primaryCalendarType, this._secondaryCalendarType, this._timestamp); | |||
| const secondMonthInfo = convertMonthNumbersToMonthNames(dateInSecType.firstDate.getMonth(), dateInSecType.lastDate.getMonth(), this._secondaryCalendarType); | |||
| const secondYearText = secondYearFormat.format(localDate, true); | |||
| const secondYearText = secondYearFormat.format(localDate, false); | |||
There was a problem hiding this comment.
false is the default value
packages/main/src/YearPicker.ts
Outdated
Comment on lines
193
to
194
| ? `${oYearFormatInSecType.format(tempDateInSecType.firstDate.toLocalJSDate(), false)}` | ||
| : `${oYearFormatInSecType.format(tempDateInSecType.firstDate.toLocalJSDate(), false)} - ${oYearFormatInSecType.format(tempDateInSecType.lastDate.toLocalJSDate(), false)}`; |
There was a problem hiding this comment.
false is the default value
tsanislavgatev
approved these changes
Jan 30, 2025
|
Let us merge the new calendar tests PR first (#10682) and you can write the test there. |
vladitasev
approved these changes
Jan 31, 2025
vladitasev
dismissed
tsanislavgatev’s stale review
We agreed to add tests later and to merge now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10633