Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed ontouched call #110

Merged
merged 3 commits into from
Jan 9, 2024
Merged

fix: fixed ontouched call #110

merged 3 commits into from
Jan 9, 2024

Conversation

g-cheishvili
Copy link
Contributor

Related Issue(s)

relates to #95

Description

  • onTouched was called only after the value change, now it is being called after focusOut. This is a temporary measure, as next iteration will change a lot.
  • Removed the distinctUntilChanged

@g-cheishvili g-cheishvili added bug Something isn't working Angular generator Topic related to the Angular Generator labels Jan 9, 2024
@g-cheishvili g-cheishvili requested a review from ilhan007 January 9, 2024 13:47
Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for ui5-webcomponents-ngx failed.

Name Link
🔨 Latest commit 9738730
🔍 Latest deploy log https://app.netlify.com/sites/ui5-webcomponents-ngx/deploys/659d4e6aa471600008d792b9

@g-cheishvili g-cheishvili merged commit aca8abd into main Jan 9, 2024
2 of 8 checks passed
@g-cheishvili g-cheishvili deleted the cva_fixes branch January 9, 2024 14:00
@markokastelec
Copy link

Hi!

@g-cheishvili: I have a problem probably connected to this change. After upgrade from version 0.2.2 to version 0.2.3 I am getting random errors like this on different components:
image

Example of the component (in this case combobox) where error happens:
image

I tried do reinstall packages (deleted node_modules and ran npm install), but errors persist. Do you have any idea how to resolve this? I was googling but didn't find any reports on this topic.

Any response will be greatly appreciated.

KR, Marko

@g-cheishvili
Copy link
Contributor Author

Very well might be, I noticed that and fixed in new pr, which is open right now

@markokastelec
Copy link

Awesome news! 👍 What is an estimate when fix will be available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Angular generator Topic related to the Angular Generator bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants