Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ui5 lifecycle service and fixed ui5 select cva #107

Closed
wants to merge 2 commits into from

Conversation

g-cheishvili
Copy link
Contributor

Related Issue(s)

closes #93

Description

  • Added service which added capability of hooking into ui5-wc lifecycle. Added onEnterDOM handlers on all cva value writes, so that we're 100% all the time that the wc is ready for value writes
  • Updated to 1.21.0 ui5 version

@g-cheishvili g-cheishvili added the Angular generator Topic related to the Angular Generator label Jan 8, 2024
@g-cheishvili g-cheishvili added this to the Sprint 129 milestone Jan 8, 2024
@g-cheishvili g-cheishvili requested review from ilhan007 and a team January 8, 2024 14:50
Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for ui5-webcomponents-ngx ready!

Name Link
🔨 Latest commit 43b13c8
🔍 Latest deploy log https://app.netlify.com/sites/ui5-webcomponents-ngx/deploys/659d30d5d675ae00088d2c05
😎 Deploy Preview https://deploy-preview-107--ui5-webcomponents-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@g-cheishvili
Copy link
Contributor Author

@ilhan007 released a patch version(0.0.0-c8721b8d2), which addresses issue with the select. So for solving that problem, this PR is not needed anymore. After those changes go into the ui5 and we update, the select problems should be done. This PR is not neccessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Angular generator Topic related to the Angular Generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select: No FormControl support
2 participants